Add option to set node name as fqdn #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some software, that relies on corosync, checks nodes status by their FQDN (with crmadmin -S). And ansible inventory_hostname may not match with hosts FQDN. In this case you may set pacemaker_corosync_fqdn: true and fqdn will be used in corosync config instead of inventory_hostname.
This patch makes pacemaker/corosync more universal, and now it's possbile to use role against CentOS 7 and CentOS 8
noonedeadpunk
force-pushed
the
master
branch
2 times, most recently
from
7ac76cd to
cf8033c
Compare
Added 2 variables - pacemaker_corosync_use_logfile and pacemaker_corosync_use_syslog which you can enable/disable to controll where corosync log will be written to.
_pacemaker_corosync_bind_addr was only generating the ip address of the current node and so on all nodes you got the same ip address.
Since CentOS 8.3 repository name has changed from HighAvailability to just ha. We need to reflect this as well
integrate pacemaker-remote
We added extra checks that pacemaker-remote group is defined. Also this adds extra variable pacemaker_remote_ring_interface that is used to determine IP address on the pacemaker remote hosts
Add CI tests
noonedeadpunk
force-pushed
the
master
branch
2 times, most recently
from
cb530fc to
8a19f20
Compare
Add testing using GitHub Actions
Add compatibility with centos-9
Instead of using fact variables we're accessing ansible_facts dictionary This is useful for cases when role is used with disabled ANSIBLE_INJECT_FACT_VARS, which improves ansible performance.
noonedeadpunk
force-pushed
the
master
branch
3 times, most recently
from
445235f to
f71e5cb
Compare
At the moment there's an issue with systemd in CentOS 8 image that prevents ansible to run properly against it.
Since we aim to support disabled inject_facts_as_vars we should test that with molecule.
Disable_inject_vars_ci
warn argument is not valid for the command module and causes newer ansible to hard fail on it.
This ensures role is executable with latest Ansible version.
Update testing stack for the role
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some software, that relies on corosync, checks nodes status by their
FQDN (with crmadmin -S). And ansible inventory_hostname may not match
with hosts FQDN. In this case you may set pacemaker_corosync_fqdn: true
and fqdn will be used in corosync config instead of inventory_hostname.