fixed annotations on assembly output for assembly-checker #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGross
requested changes
Aug 18, 2022
…e number from nat to N.
JasonGross
approved these changes
Aug 18, 2022
OwenConoly
added a commit
that referenced
this pull request
Nov 13, 2022
* fixed assembly annotation bug * included line numbers in assembly parsing errors. changed type of line number from nat to N.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the bug that caused the "overwhelmingly long list" mentioned in #1351.
The issue was caused by the assembly checker not recognizing that identical (separate) lines of assembly code were not in fact the same line. The annotations from identical lines were all lumped together, resulting in the "overwhelmingly long" annotations.