Skip to content

Commit

Permalink
Merge pull request #311 from mit-ll-responsible-ai/remove-sphinx-tabs
Browse files Browse the repository at this point in the history
remove sphinx-tabs in favor of sphinx-design (fixes dark-theme tabs)
  • Loading branch information
rsokl authored Sep 29, 2022
2 parents 33bb4a1 + ce491ad commit 8e46b85
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion docs/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ sphinx==5.1.1
pydata-sphinx-theme==0.10.1
numpydoc==1.4.0
sphinx-copybutton==0.5.0
sphinx-tabs==3.4.1
sphinx-design==0.3.0
sphinx-codeautolink==0.11.0
# third-party utilities
beartype==0.8.1
Expand Down
2 changes: 1 addition & 1 deletion docs/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"sphinx.ext.autosummary",
"numpydoc",
"sphinx_copybutton",
"sphinx_tabs.tabs",
"sphinx_design",
"sphinx_codeautolink",
]

Expand Down
7 changes: 4 additions & 3 deletions docs/source/explanation/dont_repeat_yourself.rst
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,10 @@ Statically-Defined Configs are WET

Manually writing a structured config for ``DNN`` entails hard-coding its current import-path as a string as wll as explicitly mirroring its signature:

.. tabs::

.. tab:: dataclass-based config
.. tab-set::

.. tab-item:: dataclass-based config

.. code-block:: python
:caption: Manually configuring ``DNN`` with a dataclass
Expand All @@ -56,7 +57,7 @@ Manually writing a structured config for ``DNN`` entails hard-coding its current
device: str = "cpu"
_target_: str = "vision.model.DNN"
.. tab:: yaml-based config
.. tab-item:: yaml-based config

.. code-block:: yaml
:caption: Manually configuring ``DNN`` with a YAML file
Expand Down

0 comments on commit 8e46b85

Please sign in to comment.