Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PIC for iOS #3243

Open
wants to merge 4 commits into
base: ucr
Choose a base branch
from
Open

Implement PIC for iOS #3243

wants to merge 4 commits into from

Conversation

ewpatton
Copy link
Member

General items:

If your code changes how something works on the device (i.e., it affects the companion):

  • I branched from ucr
  • My pull request has ucr as the base

Further, if you've changed the blocks language or another user-facing designer/blocks API (added a SimpleProperty, etc.):

  • I have updated the corresponding version number in YaVersion.java
  • I have updated the corresponding upgrader in YoungAndroidFormUpgrader.java (components only)
  • I have updated the corresponding entries in versioning.js

For all other changes:

  • I branched from master
  • My pull request has master as the base

What does this PR accomplish?

Description

This PR extracts the iOS-specific functionality from Simone's GSOC project with some minor reorganization of the code. I also split some of the logic in BaseAiComponent into a new BaseClassifier component to differentiate between models that perform classification (e.g., PIC, PAC) and models that report more general result structures (e.g., Facemesh).

This PR must be merged manually in order to retain the commit authorship.

SimoneSantin and others added 4 commits September 19, 2024 12:00
@SimoneSantin @ewpatton
Implement Base AI Component for iOS
2193a72 
Change-Id: I8727e0f71c4b8e2e1c4c80726c3ef44cec9c829e
@ewpatton
Make BaseAiComponent more generic
6348d52 
Change-Id: I5ee42a531ea0e0e24484d576258890dc84de3c0f
@SimoneSantin @ewpatton
Implement PersonalImageClassifier for iOS
513b2bc 
Change-Id: I4ee059d7645df138819d9ccd83a01a7d3bf06974
@ewpatton
Fix alist lookup when processing PIC results on iOS
b925a33 
Change-Id: I1426aec57cb80ac8c5daa9669a69ac36b5ffeadd
@ewpatton ewpatton added this to the iOS 2.64.6 milestone Sep 20, 2024
@ewpatton ewpatton requested a review from a team September 20, 2024 14:24
@halatmit
Copy link
Contributor

halatmit commented Sep 20, 2024 via email

daki7711
daki7711 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@daki7711 daki7711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daki7711 daki7711 daki7711 approved these changes

Assignees

@SusanRatiLane SusanRatiLane

@daki7711 daki7711

Labels
affects: ucr feature request ios pull request: needs review
Projects
None yet
Milestone
iOS 2.64.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ewpatton @halatmit @daki7711 @SusanRatiLane @SimoneSantin