add docker file #3229
Open
add docker file #3229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
ewpatton
requested changes
Aug 29, 2024
|
|
||
| # Install Java 8, curl, and Python (required for Google Cloud SDK) | ||
| RUN apt-get update && \ | ||
| apt-get install -y openjdk-8-jdk curl python3 python3-pip && \ |
There was a problem hiding this comment.
Starting in October we will no longer be deploying with Java 8. This should be changed to Java 11.
| @@ -0,0 +1,25 @@ | |||
| # Use a base image with Ubuntu | |||
| FROM mcr.microsoft.com/vscode/devcontainers/base:ubuntu | |||
There was a problem hiding this comment.
Is there a reason to use this container versus the official Ubuntu image?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.