Feature/facemesh ios #3215
Feature/facemesh ios #3215
Conversation
|
Can one of the admins verify this patch? |
| // guard let _webview = _webview else { | ||
| // throw AIError.webviewerNotSet | ||
| // } | ||
| // } |
There was a problem hiding this comment.
Let's erase all commented out code
There was a problem hiding this comment.
I've removed all the commented-out code
| // // showImagePicker() | ||
| // } | ||
| // } | ||
| // } |
| // -*- mode: conf; -*- | ||
| // Copyright 2023 MIT, All rights reserved. | ||
|
|
||
| DEVELOPMENT_TEAM = "Your Team ID here" |
There was a problem hiding this comment.
I think we need to restore this?
| @@ -352,6 +352,7 @@ | |||
| TargetAttributes = { | |||
| 06463EF71D95956800B23DCD = { | |||
| CreatedOnToolsVersion = 8.0; | |||
| DevelopmentTeam = A35W4MM59Y; | |||
There was a problem hiding this comment.
I think all of these changes shouldn't have been added during github add, in a big project never do git add . . I know it's tedious but always do git add <individual files you want to add>
There was a problem hiding this comment.
Noted. I'll be more careful with git add in the future.
| @@ -58,7 +94,7 @@ open class ImageSprite: Sprite { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Clear out these minor changes and make the code consistent as possible
| }else { | ||
| print("request not loaded") | ||
| } | ||
| showImagePicker() |
There was a problem hiding this comment.
can you align the number of shifts? in mac all you need to do is command + a and then control + i
| && normalizedAngle > 90 && normalizedAngle < 180) | ||
| || (e == Direction.southwest | ||
| && normalizedAngle > 180 && normalizedAngle < 270) | ||
| || (e == Direction.southeast && normalizedAngle > 270)) { |
There was a problem hiding this comment.
All these additional spaces seems unnecessary, can you restore them?
There was a problem hiding this comment.
I removed the extra spaces. They were probably there from before.
|
Sorry! I accidentally marked as ready for review |
No need to sorry about this, I just did it to make sure we need review. Once things work we will convert it back to ready to review. |
|
I've implemented the requested changes and pushed a new commit (913eb7f) |
Change-Id: Ia032137c1788c4672d646bc9c93c44bf0bf300bc
ewpatton
force-pushed
the
feature/facemesh-ios
branch
from
5f7650b
to
85cd7b1
Compare
|
This is now on TestFlight. |
Facemesh extension for iOS