PIC component #3187
Open
PIC component #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
…odes in both Java and Swift
SimoneSantin
force-pushed
the
feature/PIC-android
branch
3 times, most recently
from
4775d7e
to
62cf04c
Compare
|
Rather than duplicating the models at two different locations in the source tree, we should think about creating a directory under lib to hold the models. Then in components/build.xml and in the Xcode project we can set things up to copy the assets as part of the build process. |
Change-Id: I385f8c2a1249b039dee2a9fa06bbec0ac12c8539
ewpatton
reviewed
Jul 17, 2024
| if (url.contains(TRANSFER_MODEL_PREFIX)) { | ||
| Log.d(LOG_TAG, "overriding " + url); | ||
|
|
||
| file = form.openAsset(url.substring(TRANSFER_MODEL_PREFIX.length())); |
There was a problem hiding this comment.
So this line I think is an issue. You will want to fully qualify the asset using "file://android_asset/" and then the filename. Otherwise, the companion app will try to load it from the file system rather than the packaged assets.
Change-Id: Ibcb191c40655a0e2cb982642cd02289af9cc2bf6
Change-Id: I7fdcd2e1594f9faa4ea94f31090d8bff6be505e7
Change-Id: I34501cfffc55e0abf5cea8f095119015639f53a7
Change-Id: I1426aec57cb80ac8c5daa9669a69ac36b5ffeadd
|
This is now on TestFlight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting the implementation of the PIC component. Currently, only the common superclass BaseAiComponent.java has been implemented, and the PersonalImageClassifier.java file exists, although it is still empty