Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Solara integration to the third party tools #72

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

alonsosilvaallende
Copy link

@alonsosilvaallende alonsosilvaallende commented Jul 22, 2024

Add Solara integration to the third party tools.

@maartenbreddels
Copy link

Happy to review it this week!

Copy link

@maartenbreddels maartenbreddels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Alonso,

sorry for my late reply, but very excited about this. I gave some initial code suggestions, let me know if they make sense. If not, happy to help polish this code!

third_party/solara/README.md Outdated Show resolved Hide resolved
third_party/solara/README.md Outdated Show resolved Hide resolved
third_party/solara/README.md Outdated Show resolved Hide resolved
third_party/solara/README.md Outdated Show resolved Hide resolved
third_party/solara/README.md Outdated Show resolved Hide resolved
third_party/solara/README.md Outdated Show resolved Hide resolved
@alonsosilvaallende
Copy link
Author

Thank you very much @maartenbreddels
I think the code is much cleaner now.

@iisakkirotko
Copy link

Hi! What's the status on this PR?

@pandora-s-git
Copy link
Collaborator

pandora-s-git commented Oct 1, 2024

Hi, thanks so much! Before merging, would it be possible to know if the readme could be a colab notebook instead? Or it requires to be a script to work?

@maartenbreddels
Copy link

would it be possible to know if the readme could be a colab notebook instead?

Curious to know why you would want that? If the reason is to be able to change/run the code, I was actually thinking of putting it on https://py.cafe

@pandora-s-git
Copy link
Collaborator

pandora-s-git commented Oct 3, 2024

Its mostly to be able to run easily the code yes, since as a jupyter notebook for colab we can easily mention it on the docs and redirect the users to a colab for them to run the code. Most of the cookbooks are jupyter notebooks too unless that is not feasible.

However if that is not possible its fine, py.cafe however does sound like a cool idea.

@maartenbreddels
Copy link

I'll work with @alonsosilvaallende to get the first example on py.cafe (requires some development for the PyCafe team to support secrets, this should take ~1 week max).

Due to the faiss dependency, we cannot run the chat with a pdf on PyCafe (yet).

@alonsosilvaallende what do you think, does it make sense to turn the chat with pdf example into a notebook, so we can include a colab link?

@alonsosilvaallende
Copy link
Author

I'll work with @alonsosilvaallende to get the first example on py.cafe (requires some development for the PyCafe team to support secrets, this should take ~1 week max).

Due to the faiss dependency, we cannot run the chat with a pdf on PyCafe (yet).

@alonsosilvaallende what do you think, does it make sense to turn the chat with pdf example into a notebook, so we can include a colab link?

Thank you @maartenbreddels Yes, we can do a colab with the chat with pdf example. If I remember correctly there was a problem with threads with colab and chat but I will check again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants