-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 登録時のエラーを詳細に表示するように #14927
base: develop
Are you sure you want to change the base?
fix: 登録時のエラーを詳細に表示するように #14927
Conversation
このPRによるapi.jsonの差分 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14927 +/- ##
===========================================
- Coverage 39.47% 39.44% -0.03%
===========================================
Files 1560 1560
Lines 197061 197189 +128
Branches 2576 3612 +1036
===========================================
+ Hits 77784 77788 +4
- Misses 118705 118829 +124
Partials 572 572 ☔ View full report in Codecov by Sentry. |
invitationCodeInvalid: "招待コードが入力されていないか、不正な値です。" | ||
invitationCodeNotFoundOrUsed: "招待コードが見つからなかったか、既に使用されています。" | ||
invitationCodeExpired: "招待コードの有効期限が切れています。" | ||
usernameAlreadyUsed: "このユーザー名は既に使用されています。" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これってクライアント側で予めわからないかしら
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ユーザー名とかはわかるようになっている(押せないようになっている)けど招待コードは事前にチェックとかが入らないのでわからない
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ならusernameAlreadyUsedは不要だわね
What
Why
#14522 の一環
Additional info (optional)
Checklist