Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 登録時のエラーを詳細に表示するように #14927

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

What

  • 登録時にエラーが発生した場合内容を表示するように

Why

#14522 の一環

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels Nov 9, 2024
Copy link
Contributor

github-actions bot commented Nov 9, 2024

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 1.14943% with 172 lines in your changes missing coverage. Please review.

Project coverage is 39.44%. Comparing base (1bc4f40) to head (50e4ad9).

Files with missing lines Patch % Lines
...ackages/backend/src/server/api/SignupApiService.ts 1.00% 99 Missing ⚠️
...es/frontend/src/components/MkSignupDialog.form.vue 0.00% 65 Missing ⚠️
packages/backend/src/core/SignupService.ts 11.11% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14927      +/-   ##
===========================================
- Coverage    39.47%   39.44%   -0.03%     
===========================================
  Files         1560     1560              
  Lines       197061   197189     +128     
  Branches      2576     3612    +1036     
===========================================
+ Hits         77784    77788       +4     
- Misses      118705   118829     +124     
  Partials       572      572              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

invitationCodeInvalid: "招待コードが入力されていないか、不正な値です。"
invitationCodeNotFoundOrUsed: "招待コードが見つからなかったか、既に使用されています。"
invitationCodeExpired: "招待コードの有効期限が切れています。"
usernameAlreadyUsed: "このユーザー名は既に使用されています。"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これってクライアント側で予めわからないかしら

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ユーザー名とかはわかるようになっている(押せないようになっている)けど招待コードは事前にチェックとかが入らないのでわからない

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ならusernameAlreadyUsedは不要だわね

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants