skip coils without hardware drivers when generating coil info for service menu

[bosh]

#1874 resolution - skip coils without hw_drivers (such as dual wound coils) for service controller use cases

[avanwinkle]

Interesting! I honestly had no idea that dual wound coils existed in MPF, but glad to know!

Service mode definitely shouldn't crash on them, and should know what they are. Something like

for coil in self.machine.coils.values():
  if coil is DualWoundCoil:
    continue
  ...

So that takes care of the dual wound coils. As for other coils, that assert statement is pretty old and I'm not wild about crashing the game unnecessarily, so maybe replacing the assert with an if statement and logging a warning that the coil has no hardware driver and won't be included. That's a nicer approach that won't break the game but still informs the user of the issue. Putting that line after the DualWoundCoil check will acknowledge that dual wound coils are expected and don't need a warning.

Thanks for working on this!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[bosh]

This is ready to go, if tests are green. I added to the service test config file -- the new device declaration would have caused testServiceCli and testServiceMode to crash without the fix, but with the fix there's nothing new to see or assert on.

I went with the class check, but TBH I slightly prefer the has_attr("hw_driver") variant I had written previously. Upside of not using the class check is one less import, and the place I cribbed from suggested there might be other objects in machine.coils that also don't have a hw_driver. (Driver.py:53)