Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VPE dependencies and rebuild interface #1865

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

arthurkehrwald
Copy link

@arthurkehrwald arthurkehrwald commented Jan 20, 2025

I installed the latest versions of grpcio, grpciotools and protobuf, regenerated the platform interface scripts using mpf/platforms/visual_pinball_engine/generate.py and tested it with VPE.

Fixes #1864

Copy link
Collaborator

@avanwinkle avanwinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're generally reticent to roll package upgrades because they can cause downstream issues, but all the tests passed and we gotta do it sometime, right?

Thanks for taking care of this!

@arthurkehrwald
Copy link
Author

I've added a new RPC to the service definition. It is a simple ping function that I will use in the VPE integration to check if MPF is ready. Previously, VPE simply waited for 1,5 seconds and assumed it was ready, but this can fail on slow computers and wastes time on fast ones. GRPC provides ways to wait for the connection to be ready that would be preferrable, but they are not supported on grpc-dotnet with .netstandard2.1.

@arthurkehrwald
Copy link
Author

I've added the MPF version to the ping response so VPE can accommodate different versions of MPF in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pip installation of VPE dependencies fails on Python >3.9
2 participants