Faux PR #2
Draft
Faux PR #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bump to move out of stalled |
Change-Id: Ie2d972df025f6b6b7d172015aae7eb34e355cb28 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/412034 Reviewed-by: Matt Hickford <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Cody Oss <[email protected]> Reviewed-by: Matthew Hickford <[email protected]> Run-TryBot: Matt Hickford <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Cody Oss <[email protected]>
With Context Aware Access enabled, users must use the endpoint "https://oauth2.mtls.googleapis.com/token" for token exchange. This PR adds support for runtime configuration of the OAuth2 token endpoint (as determined by the caller). If using the mTLS oauth2 endpoint, the caller will also need to specify an mTLS-enabled HTTPClient via the "context" mechanism for use by the OAuth2 transport. Change-Id: Ic83342ec1d224d3acdabf00d863249330424fc54 GitHub-Last-Rev: 07e4849 GitHub-Pull-Request: #630 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/470396 Run-TryBot: Matthew Hickford <[email protected]> Reviewed-by: Shin Fan <[email protected]> Run-TryBot: Shin Fan <[email protected]> Reviewed-by: Matthew Hickford <[email protected]> Reviewed-by: Andy Zhao <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Once this CL is submitted, and post-submit testing succeeds on all first-class ports across all supported Go versions, this repository will be tagged with its next minor version. Change-Id: If7957dff90ca75fa8fd84ace90ed15066bfd3e48 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/473438 Reviewed-by: Heschi Kreinick <[email protected]> Auto-Submit: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Gopher Robot <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
Text verbatim from https://go.dev/doc/contribute Change-Id: Iefdcf9e9f771b9e55601bf9c9b59e20593b4573a GitHub-Last-Rev: ba45caa GitHub-Pull-Request: #632 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/471281 Run-TryBot: Matthew Hickford <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]> Reviewed-by: Matthew Hickford <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
Update the URL to a newer page that better describes how to set up credentials in different environments. Change-Id: Ic0726fe298c543265d333cda60d62c235e4e2293 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/473735 Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Cody Oss <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Cody Oss <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
Fixing dead links in workload docs, adds workforce documentation Change-Id: Ifad86e1937997f96ef577f5469d1e6fe496197b5 GitHub-Last-Rev: af28808 GitHub-Pull-Request: #638 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/478555 Auto-Submit: Cody Oss <[email protected]> Reviewed-by: Leo Siracusa <[email protected]> Reviewed-by: Cody Oss <[email protected]> Run-TryBot: Cody Oss <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
Change-Id: I515f8897cc79c58a8a49df84ccddc5acd9536d87 GitHub-Last-Rev: 5acbebb GitHub-Pull-Request: #616 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/459695 Run-TryBot: Cody Oss <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Cody Oss <[email protected]> Reviewed-by: Matt Hickford <[email protected]>
Add a constructor which allows for the configuration of the expiryDelta buffer. Due to the construction of reuseTokenSource and Token we need to store the new delta in both places, so the behavior of Valid is consistent regardless of where it is called from. Fixes #623 Change-Id: I89f9c206a9cc16bb473b8c619605c8410a82fff0 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/479676 Run-TryBot: Roland Shoemaker <[email protected]> Reviewed-by: Cody Oss <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
This option is a followup to to cl/479676 where an option was added to configure the preemptive token refresh. Currently the option in this package is only being used by compute credentials. In the future we can support more/all auth flows but that would require a lot of new surfaces to be added. Compute credentials are currently the only case where we are expirencing the need to configure this setting. Change-Id: Ib78ca4beec44d0fe030ae81e84c8fcc4924793ba Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/479956 Run-TryBot: Cody Oss <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Roland Shoemaker <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Once this CL is submitted, and post-submit testing succeeds on all first-class ports across all supported Go versions, this repository will be tagged with its next minor version. Change-Id: If1689e1b37e36e8e8dd1cfc37fe9cb94bd49c807 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/482856 TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Gopher Robot <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Run-TryBot: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
Parse error response described in https://datatracker.ietf.org/doc/html/rfc6749#section-5.2 Handle unorthodox servers responding 200 in error case. Implements API changes in accepted proposal golang/go#58125 Fixes #441 Fixes #274 Updates #173 Change-Id: If9399c3f952ac0501edbeefeb3a71ed057ca8d37 GitHub-Last-Rev: 0030e27 GitHub-Pull-Request: #610 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/451076 Run-TryBot: Matt Hickford <[email protected]> Run-TryBot: Damien Neil <[email protected]> Reviewed-by: Matt Hickford <[email protected]> Reviewed-by: Damien Neil <[email protected]> Reviewed-by: Cody Oss <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
Change-Id: I0ce35bd2b7b870de9c0ffd898f245b49edbe55f7 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/489715 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: shuang cui <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Bryan Mills <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Once this CL is submitted, and post-submit testing succeeds on all first-class ports across all supported Go versions, this repository will be tagged with its next minor version. Change-Id: I97dfa241b763dfba4fc0c02da2f241255e2f53d1 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/493576 Reviewed-by: Heschi Kreinick <[email protected]> Auto-Submit: Gopher Robot <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Gopher Robot <[email protected]>
There are cases when reading this file that a ENOTDIR is returned. Because of this it is safer to just fall-back when any error happens from reading the gcloud file. Change-Id: Ie8e45ad508643e900adb5c9787907aaa50cceb5d Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/493695 Run-TryBot: Cody Oss <[email protected]> Reviewed-by: Russ Cox <[email protected]> Auto-Submit: Cody Oss <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Once this CL is submitted, and post-submit testing succeeds on all first-class ports across all supported Go versions, this repository will be tagged with its next minor version. Change-Id: I7a693f42e110b957194337a0d355dd1f2a5e14ca Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/502797 Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Gopher Robot <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Run-TryBot: Gopher Robot <[email protected]>
This change was prepared by running: go1.21rc2 get -u -t ./... go1.21rc2 mod tidy -compat=1.17 Change-Id: I533c4361aae073b7a5280aad2c2e5eea752df62a Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/506296 Reviewed-by: Cody Oss <[email protected]> Run-TryBot: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Bryan Mills <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Once this CL is submitted, and post-submit testing succeeds on all first-class ports across all supported Go versions, this repository will be tagged with its next minor version. Change-Id: I6b389549fe4bc53a62cb383c5fb10156ccfcffba Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/507840 Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Gopher Robot <[email protected]> Auto-Submit: Gopher Robot <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]>
Go versions 1.16 and 1.17 are long since unsupported per Go release policy (https://go.dev/doc/devel/release#policy). Updating go.mod's go statement to 1.18 makes it so that 'go mod tidy' doesn't include checksums needed for the full module graph loaded by Go 1.16¹ that were recently added in CL 507840. It also makes go fix remove the now-obsolete // +build lines². Done using cmd/go at go1.21rc2: $ go get [email protected] go: upgraded go 1.17 => 1.18 $ go mod tidy $ go fix ./... google/appengine_gen1.go: fixed buildtag google/appengine_gen2_flex.go: fixed buildtag internal/client_appengine.go: fixed buildtag ¹ https://go.dev/ref/mod#graph-pruning ² https://go.dev/doc/go1.18#go-build-lines Change-Id: I6c6295adef1f5c64a196c2e66005763893efe5e7 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/507878 Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Cody Oss <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Once this CL is submitted, and post-submit testing succeeds on all first-class ports across all supported Go versions, this repository will be tagged with its next minor version. Change-Id: I953aeb97bb9ed634f69dc93cf1f21392261c930c Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/516037 Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Gopher Robot <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Auto-Submit: Gopher Robot <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
In 80673b4 (https://go.dev/cl/157820) I added a never-shrinking package-global cache to remember which auto-detected auth style (HTTP headers vs POST) was supported by a certain OAuth2 server, keyed by its URL. Unfortunately, some multi-tenant SaaS OIDC servers behave poorly and have one global OpenID configuration document for all of their customers which says ("we support all auth styles! you pick!") but then give each customer control of which style they specifically accept. This is bogus behavior on their part, but the oauth2 package's global caching per URL isn't helping. (It's also bad to have a package-global cache that can never be GC'ed) So, this change moves the cache to hang off the oauth *Configs instead. Unfortunately, it does so with some backwards compatiblity compromises (an atomic.Value hack), lest people are using old versions of Go still or copying a Config by value, both of which this package previously accidentally supported, even though they weren't tested. This change also means that anybody that's repeatedly making ephemeral oauth.Configs without an explicit auth style will be losing & reinitializing their cache on any auth style failures + fallbacks to the other style. I think that should be pretty rare. People seem to make an oauth2.Config once earlier and stash it away somewhere (often deep in a token fetcher or HTTP client/transport). Change-Id: I91f107368ab3c3d77bc425eeef65372a589feb7b Signed-off-by: Brad Fitzpatrick <[email protected]> Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/515675 TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Roland Shoemaker <[email protected]> Reviewed-by: Adrian Dewhurst <[email protected]> Reviewed-by: Michael Knyszek <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I2fb95ca59417e20377bc315094221fa7165128c8 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/525675 Reviewed-by: Heschi Kreinick <[email protected]> Run-TryBot: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Gopher Robot <[email protected]>
Device Authorization Grant following RFC 8628 https://datatracker.ietf.org/doc/html/rfc8628 Tested with GitHub Fixes #418 Fixes golang/go#58126 Co-authored-by: cmP <[email protected]> Change-Id: Id588867110c6a5289bf1026da5d7ead88f9c7d14 GitHub-Last-Rev: 9a126d7 GitHub-Pull-Request: #609 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/450155 Commit-Queue: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Than McIntosh <[email protected]> Auto-Submit: Bryan Mills <[email protected]> Run-TryBot: Matt Hickford <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Run-TryBot: Bryan Mills <[email protected]>
Fixes #603 Fixes golang/go#59835 Change-Id: Ica0cfef975ba9511e00f097498d33ba27dafca0d GitHub-Last-Rev: f01f759 GitHub-Pull-Request: #625 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/463979 Reviewed-by: Cherry Mui <[email protected]> Run-TryBot: Matt Hickford <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Roland Shoemaker <[email protected]>
Remove the url validations to keep a consistency with other libraries. Change-Id: Icb1767edc000d9695db3f0c7ca271918fb2083f5 GitHub-Last-Rev: af89ee0 GitHub-Pull-Request: #660 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/522395 Reviewed-by: Leo Siracusa <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Cody Oss <[email protected]> Run-TryBot: Cody Oss <[email protected]>
Change-Id: I36eb5eb66099161785160f4f39ea1c7f64ad6e74 GitHub-Last-Rev: 31cfe81 GitHub-Pull-Request: #664 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/526302 Reviewed-by: Matthew Dempsky <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Bryan Mills <[email protected]> Reviewed-by: Bryan Mills <[email protected]>
Adds framework for sending BYOID metrics via the x-goog-api-client header on outgoing sts requests. Also adds a header file for getting the current version of GoLang Change-Id: Id5431def96f4cfc03e4ada01d5fb8cac8cfa56a9 GitHub-Last-Rev: c93cd47 GitHub-Pull-Request: #661 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/523595 Reviewed-by: Leo Siracusa <[email protected]> Run-TryBot: Cody Oss <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Cody Oss <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: Iad79e50dacd89c4cd0a40d966a1a7ba4cdc3d1a4 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/545176 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Auto-Submit: Gopher Robot <[email protected]>
Change-Id: I7925b8341e1f047d0115acd7a01a34679a489ee0 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/552716 Reviewed-by: Cody Oss <[email protected]> Run-TryBot: Cody Oss <[email protected]> Reviewed-by: Viacheslav Rostovtsev <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
* Deprecate Credentials.UniverseDomain Change-Id: I1cbc842fbfce35540c8dff99fec09e036b9e2cdf Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/554215 TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Cody Oss <[email protected]> Auto-Submit: Cody Oss <[email protected]> Reviewed-by: Cody Oss <[email protected]> Reviewed-by: Viacheslav Rostovtsev <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: Icf68cb33585a13df206afacdb79832ea76f82346 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/554676 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Than McIntosh <[email protected]> Auto-Submit: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
Change-Id: I3669352b382414ea640ca176afa4071995fc5ff1 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/557135 Reviewed-by: Cody Oss <[email protected]> TryBot-Bypass: Cody Oss <[email protected]> Auto-Submit: Cody Oss <[email protected]>
… to support universe domain Change-Id: Iafe35c293209bd88997c876341ebde7ac9ecda93 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/557195 TryBot-Bypass: Cody Oss <[email protected]> Reviewed-by: Cody Oss <[email protected]> Auto-Submit: Cody Oss <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I8228a126b322fb14250bbb5933199ce45e8584d3 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/562496 Reviewed-by: Than McIntosh <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Gopher Robot <[email protected]>
… and exports it go/programmable-auth-design for context. Adds support for user defined supplier methods to return subject tokens and AWS security credentials. Change-Id: I7bc41f8c5202ae933fce516632f5049bbeb3d378 GitHub-Last-Rev: ac519b2 GitHub-Pull-Request: #690 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/550835 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Leo Siracusa <[email protected]> Reviewed-by: Chris Smith <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Cody Oss <[email protected]>
Change-Id: Ia1caee246da68c01addd06e1367ed1e43645826b Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/568216 Reviewed-by: Alex Eitzman <[email protected]> Reviewed-by: Cody Oss <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
Update golang.org/x dependencies to their latest tagged versions. Change-Id: I993c77edbea8426f558ab84c4ba769e0bdf6406d Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/568935 Reviewed-by: Than McIntosh <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Gopher Robot <[email protected]> Reviewed-by: Michael Knyszek <[email protected]>
This library no longer builds on Go versions prior to Go 1.17, so no longer needs to support compilation specific to AppEngine environments on Go versions prior to Go 1.11 Related to #615 Change-Id: Ia9579ea2091cb86ee96065affb920370c4ba33ea Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/570595 Reviewed-by: Matt Hickford <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Cody Oss <[email protected]> Run-TryBot: Matt Hickford <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
This is a fix on the googleapis/google-cloud-go#9508. The aws provider in that library is a ported dependency from here. Change-Id: I28e1efa4fdb8292210b695a164a55060c83dae88 GitHub-Last-Rev: c425f2d GitHub-Pull-Request: #711 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/570875 Reviewed-by: Cody Oss <[email protected]> Reviewed-by: Chris Smith <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
The sts response contains an optional field of `expires_in` and the value can be any integer. https://github.com/golang/oauth2/blob/master/google/internal/externalaccount/basecredentials.go#L246-L248 In the case of less than `0`, we are going to throw an error. But in the case of equals to `0` practically it means "never expire" instead of "instantly expire" which doesn't make sense. So we need to not set the expiration value for Token object. The current else if greater or equal is wrong. It's never triggered only because we are sending positive `3600` in sts response. Change-Id: Id227ca71130855235572b65ab178681e80d0da3a GitHub-Last-Rev: a95c923 GitHub-Pull-Request: #687 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/545895 Reviewed-by: Shin Fan <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Cody Oss <[email protected]> Reviewed-by: Cody Oss <[email protected]>
* move MDS universe retrieval within Compute credentials Change-Id: I847d2075ca11bde998a06220307626e902230c23 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/575936 Reviewed-by: Cody Oss <[email protected]> Auto-Submit: Cody Oss <[email protected]> Run-TryBot: Cody Oss <[email protected]> TryBot-Result: Gopher Robot <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
The Microsoft identity platform supports the device authorization grant: https://learn.microsoft.com/en-us/entra/identity-platform/v2-oauth2-device-code This PR adds the "https://login.microsoftonline.com/{tenant}/oauth2/v2.0/devicecode" DeviceAuthURL to the AzureADEndpoint. Fixes #700 Change-Id: I8ca571391e0e0f4d383e3f2f07a66b26edcb4679 GitHub-Last-Rev: 2b953c3 GitHub-Pull-Request: #701 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/564315 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Matt Hickford <[email protected]> Run-TryBot: Matt Hickford <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Than McIntosh <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
Related #615 Related googleapis/google-cloud-go#9545 Change-Id: I762dc53c61204ec5103336dab6358b9b4d1337d4 GitHub-Last-Rev: 439c393 GitHub-Pull-Request: #719 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/579495 Reviewed-by: Cody Oss <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Cody Oss <[email protected]> Reviewed-by: Jordan Liggitt <[email protected]>
Change-Id: Ifc12ed36671d21e388c537c510a82be084e9ec99 GitHub-Last-Rev: a4da759 GitHub-Pull-Request: #720 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/580715 TryBot-Bypass: Cody Oss <[email protected]> Reviewed-by: Cody Oss <[email protected]> Reviewed-by: Joedian Reid <[email protected]>
The shortest MDS token cache time is 4 minutes. The refresh window is updated to 3 minutes and 45 seconds to give the MDS time to update it's cache. This should make slow refreshes less likely to cause failures. Done in googleapis/google-cloud-go#9139 for the other auth library. Change-Id: Ifa353248197d8998e6b0363d1f2821b45a0e6495 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/584815 Auto-Submit: Cody Oss <[email protected]> TryBot-Bypass: Cody Oss <[email protected]> Run-TryBot: Cody Oss <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Cody Oss <[email protected]>
Very minor tweaks: - Remove (c) pseudosymbol. - Remove "All Rights Reserved." - Change "Google Inc." (no longer exists) to "Google LLC". [git-generate] echo ' ,s/\(c\) // ,s/ All rights reserved.// ,s/Google Inc./Google LLC/ w q ' | sam -d LICENSE Change-Id: I75efc3e2705b75748034e46a093bb71cb40eee5b Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/598580 Auto-Submit: Russ Cox <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
See GitLab documentation https://docs.gitlab.com/ee/api/oauth2.html#device-authorization-grant-flow. Change-Id: Ideffbfcb67e0b25251a0b18148e57eab43124d37 GitHub-Last-Rev: 6ecd45e GitHub-Pull-Request: #733 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/600095 TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Matt Hickford <[email protected]> Reviewed-by: Matt Hickford <[email protected]> Reviewed-by: Michael Knyszek <[email protected]> Reviewed-by: David Chase <[email protected]> TryBot-Bypass: Matt Hickford <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
After CL 603476 we were getting jwt/example_test.go:13:1: ExampleJWTConfig refers to unknown identifier: JWTConfig Change-Id: I51bcd06a50a852150eb6e42743431207ee00300f Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/606878 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Alan Donovan <[email protected]>
Fixes golang/go#61417 Change-Id: Ib8599f39b4839bf6eed021217350195ad36d1631 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/605955 Reviewed-by: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Cherry Mui <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
These days people will just import the packages and the go tool will do the right thing. We don't need to explain it. Add a pointer to the git repo, though. For golang/go#62645 Change-Id: Ib6a6fb8989df8071b20d50de446d05b270c1f1ae Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/624195 Commit-Queue: Ian Lance Taylor <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Cody Oss <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]>
Change-Id: I9fd025393acc12da59fdac1c416563324cd26af1 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/639695 Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Cherry Mui <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
Change-Id: Ic2ce6e9c3ed735f4fc6d78a22cf0d5e95fca91a1 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/643158 TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Sai Sunder Srinivasan <[email protected]> Run-TryBot: Cody Oss <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Cody Oss <[email protected]>
Adds the patreon endpoints from their documentation. https://docs.patreon.com/#oauth. I've tested these thoroughly whilst making a pr to pocketbase. pocketbase/pocketbase#3323. Change-Id: I023871a4340ee4ebcba9fd808d4a8f0c081fc10e GitHub-Last-Rev: 890ef05 GitHub-Pull-Request: #668 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/528640 Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Reviewed-by: Jorropo <[email protected]> Auto-Submit: Jorropo <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
Config.DeviceAccess should be Config.DeviceAuth when using GenerateVerifier() or S256ChallengeOption() Change-Id: Ie21a808387f731d270ae54ea1705de3e786cad7f GitHub-Last-Rev: 2d6b4fd GitHub-Pull-Request: #763 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/636216 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Cherry Mui <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Jorropo <[email protected]> Reviewed-by: Jorropo <[email protected]>
Endpoints are provided from https://discord.com/developers/docs/topics/oauth2#shared-resources-oauth2-urls. Change-Id: I7bcc8b4cb5527959acb8f177ffb8bbafbe727e82 GitHub-Last-Rev: 6869fc3 GitHub-Pull-Request: #768 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/649115 Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
By now Go 1.24.0 has been released, and Go 1.22 is no longer supported per the Go Release Policy (https://go.dev/doc/devel/release#policy). For golang/go#69095. [git-generate] (cd . && go get [email protected] && go mod tidy && go fix ./... && go mod edit -toolchain=none) Change-Id: I718ce0afa60729aeb89396db2b559faf03b90a68 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/649795 Auto-Submit: Gopher Robot <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Cherry Mui <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.