Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to skip gpg verification #8

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

kroleg
Copy link

@kroleg kroleg commented Apr 10, 2024

Latest v1 releases (1.22.22, 1.22.21, 1.22.20) don't have signature files (.asc) which makes it impossible to install these versions (gpg signature verification doesn't pass). They say "we're working on fixing this" but issue persists since Nov 14, 2023 (release of 1.22.20)

There is also an issue in original repo twuni#33

evidence

skipping gpg verification (curl)
Screenshot 2024-04-10 at 19 54 55

skipping gpg verification (wget with --no-verbose added only for test to shorten output)
Screenshot 2024-04-10 at 21 01 11

gpg still required if no env var set
Screenshot 2024-04-10 at 19 54 23

latest version install fails without flag (curl)
Screenshot 2024-04-10 at 19 51 25

latest version install fails without flag (wget with --no-verbose added only for test to shorten output)
Screenshot 2024-04-10 at 21 00 57

@kroleg kroleg force-pushed the ability-to-skip-gpg branch from 65528f0 to fbabe09 Compare April 10, 2024 18:00
- latest versions 1.22.20 - 1.22.22 don't have .asc signature file which makes it impossible to install these versions
- needed to split tar and gpg deps to allow to skip gpg
- got  [ -z ${MISE_YARN_SKIP_GPG+false} ]  idea from https://stackoverflow.com/a/13864829/832965
@kroleg kroleg force-pushed the ability-to-skip-gpg branch from fbabe09 to ec9ab08 Compare April 10, 2024 18:04
@kroleg kroleg marked this pull request as ready for review April 10, 2024 18:06
@kroleg
Copy link
Author

kroleg commented Apr 12, 2024

@jdx i've removed dependency on #7, can merge this one separately

@jdx jdx merged commit 0ccfea8 into mise-plugins:main Apr 12, 2024
4 checks passed
@kroleg kroleg deleted the ability-to-skip-gpg branch April 20, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants