Fix monolog channels #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove these services if Monolog is not available. This way, loggers can use the `guzzle` channel assigned by the service definition and not the `app` channel.
Monolog only assigns log channels to those services that depend on the `logger` service, not the `monolog.logger`.
|
Any news on this? |
|
Any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load Monolog services by default (if logging is enabled), and remove them afterwards in the compiler pass if Monolog is not available. This way, the log adapter will use the
guzzlechannel properly, assigned by the service definition and not the default channelapp, as it does now.Fixes #35
In my use case, I wanted to exclude all the Guzzle logs from a command output, but I couldn't since those logs were being logged into the
appchannel.