Update Guzzle profiler & data collector from ludofleury/GuzzleBundle

[ludofleury]

No description provided.

[ludofleury]

Start #28 ! @thewilkybarkid @mtdowling @ddeboer @Ismith77

[ddeboer]

Cool, let's merge this!

[zerrvox]

Would love to see this be merged and a new release tagged 👍

[mattvick]

+1 I agree would love to see these merged.

[alex-pex]

I have an issue with current profiler which log the call 3 times instead of one (an error_log shows that it is only called once).
I would love to see if the new profiler fixes this issue.

[tristanbes]

+1

[zerrvox]

bump

[adrian-ludwig]

+1

[bendavies]

+1 @thewilkybarkid

[bendavies]

@thewilkybarkid any hold up? i'd be happy to fix any issues if you aren''t happy with this PR (if @ludofleury isn't available)

[thewilkybarkid]

It's generally really good, but it would need rebasing due some recent changes.

Couple of things I can spot are:

• The config should be changed so that it's enabled by default (if you're using the profile it's probably rarer that you don't want this pane than do).
• The history plugin has a limit of 10 requests by default, this should be increased as we don't want to lose any (make it 1,000 just to be safe?)

If some could rebase these changes I'll take a proper look. When it's sorted I'll then tag a new version. Cheers.

[ludofleury]

All right. I'll work on it.

On Dec 24, 2013 10:37 AM, "Chris Wilkinson" [email protected]
wrote:

It's generally really good, but it would need rebasing due some recent
changes.

Couple of things I can spot are:

• The config should be changed so that it's enabled by default (if
  you're using the profile it's probably rarer that you don't want this pane
  than do).
• The history plugin has a limit of 10 requests by default, this
  should be increased as we don't want to lose any (make it 1,000 just to be
  safe?)

If some could rebase these changes I'll take a proper look. When it's
sorted I'll then tag a new version. Cheers.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/29#issuecomment-31165212
.

[ludofleury]

🎅 Ho ho ho! Update!

• Removed profiler configuration. Now the profiler is enabled if we have the WebProfilerBundle enabled.
• Defined the history plugin limit to 1K as default. It stills a parameter.
• Fixed prettify display of Request / Response body
• Removed the minified & worthless profiler.min.css stylesheet

Note that I'm still using Iterator access on history plugin for BC. Maybe it's worthless ? More information on the stub class for test

There is many commits for readability, could be rebased to 1.

Merry christmas!

[thewilkybarkid]

Had a good look through it last night (and once I'd added in the missing dependencies) immediately hit the divide by-zero bug.

Some of the language will need to be cleaned up, I'll go through and point out the changes. (As an aside, it would be good to have translations - that's for a future PR though.)

Could you revert the profiler logo? I would ultimately like a better version of the Guzzle icon, but it would be better in a different discussion.

The main area though is that I'm not a big fan of bundling external dependencies. Having look through them I think it reasonably straightforward to lose them:

• The jQuery piece can be rewritten in vanilla JS (there isn't that much so a framework is a bit overkill).
• Font Awesome doesn't appear to do much, so should be replaced by images (is it just the status icon?).
• The syntax highlighting, while nice, could be made optional. If there were a config option for the script path it could include it if defined (the docs could point the user at the Google Code hosted version, or they could use Bower, Components or whatever).

[bendavies]

@ludofleury any chance to look at this?

[ludofleury]

Hi, just got a new position right now, so a bit out of time for the next week.
I agree totally with you, I was thinking exactly the same when I rebased the PR in december. The front is cheaply done and need a serious cleaning. I'll try to get this done as fast as possible.

Unless someone could help to get ride of the js vendor.

[bendavies]

the jquery requirement is just for slideToggle? if so it can just be replaced with Sfjs.toggle(...) or Sfjs.addClass(...)/Sfjs.removeClass(...)

[ludofleury]

I'm sorry, I still don't have any free time at the moment to take care of this, rush hour here.

[adrienbrault]

@ludofleury ping 😃

[ludofleury]

OK. I'll try. Damn you :D

Ludovic Fleury
Paris, France.

+33 (0)6 18 50 47 24

Get some IT / Devops news on twitter: @ludofleury
Watch my open-source contributions on github: ludofleury
Read feedback about my experiences: http://testonsteroid.tumblr.com

On Apr 2, 2014 11:35 PM, "Adrien Brault" [email protected] wrote:

@ludofleury https://github.com/ludofleury ping [image: 😃]

Reply to this email directly or view it on GitHubhttps://github.com//pull/29#issuecomment-39386977
.

[rvgate]

+1 Any updates on this? Just started to convert one of our project to use guzzle-bundle, a more detailed debugger would be awesome!

[jenkoian]

Any updates on this @ludofleury? I noticed @bendavies offered to pick up any issues above? Could that be an option?

[rvgate]

@jenkoian Check #57, maybe speeds up the process a bit.

[ludofleury]

This PR is now #57