Add support for mariadb + default authentication plugin #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests fail, while on my fork they don't https://github.com/haltuf/mysql-action/commit/1d829fdd34e83de9a72b768924ec109f83e4d78c/checks?check_suite_id=323723363 I believe the problem is, that my PR tries to reach your ${{ secrets.DatabasePassword }} to which it obviously does not have access. |
|
This PR would be useful for us as we are looking to fallback to the default authentication plugin and could not find a way to do so. |
|
Are you planning on merging this |
|
@haltuf Thanks for writing this PR, saved me a lot of time |
daniellockyer
added a commit
to daniellockyer/mysql-action
that referenced
this pull request
Jan 25, 2022
refs mirromutth#7 - I've pulled the code from the PR that allows us to change the authentication plugin, so we can run tests on 8.0 until the PR is merged
thygasantos
approved these changes
Mar 26, 2023
|
Is this going to be merged at any point? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
The thing is, mysql 8.0+ changed its default authentication plugin from 'mysql_native_password' to 'caching_sha2_password' causing 'The server requested authentication method unknown to the client [caching_sha2_password]' error for many applications. Setting the default value to 'mysql_native_password' enforces the standard login/password authentication even for mysql 8.0+ versions.
I've also added the tests to cover new functionality.