Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More reliable RateLimiter #178

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Conversation

alireza-sheikholmolouki
Copy link
Member

@alireza-sheikholmolouki alireza-sheikholmolouki commented Sep 20, 2024

This PR involves several changes:

  • the overall rate-limiting functionality should work
  • switched our rate-limiting approach from windowed throttling to strict throttling. Instead of counting how many requests fit within a specific time frame, we now enforce strict time gaps between requests.
  • rate-limiter now accepts pause, resume and abort which could be later used for more advanced functionalities
  • a new concept called RetryStrategy is defined in which you can define when to retry and how to retry
  • an AWSRateLimitExhaustionRetryStrategy added based on RetryStrategy abstract and used in CLI app. also exposed via the lib

Copy link

changeset-bot bot commented Sep 20, 2024

🦋 Changeset detected

Latest commit: e8d8c33

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@mirohq/cloud-data-import Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alireza-sheikholmolouki alireza-sheikholmolouki changed the title More Reliable and Advanced Rate Limiter More reliable and advanced RateLimiter Sep 20, 2024
@alireza-sheikholmolouki alireza-sheikholmolouki changed the title More reliable and advanced RateLimiter More reliable RateLimiter Sep 20, 2024
@alireza-sheikholmolouki alireza-sheikholmolouki marked this pull request as ready for review September 20, 2024 16:03
andries-miro
andries-miro previously approved these changes Sep 23, 2024
@alireza-sheikholmolouki alireza-sheikholmolouki merged commit b240bf1 into main Sep 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants