Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Rails 8 #80

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Allow Rails 8 #80

merged 1 commit into from
Jan 23, 2025

Conversation

ScotterC
Copy link
Contributor

I haven't tested this locally but thought I'd submit to see if it was an easy CI pass.

I haven't tested this locally but thought I'd submit to see if it was an easy CI pass.
@kucho
Copy link

kucho commented Nov 30, 2024

This is blocking the upgrade path for one of our apps. How can I help to get this merged?

@schinery
Copy link

This is blocking the upgrade path for one of our apps. How can I help to get this merged?

Same, any chance someone can give this a look and get it released? 🙏🏻

@schinery
Copy link

Sorry to tag you @remi, but as you did the last release of this gem is this something you would be able to sort out?

@devsheva
Copy link

I have tested this locally with the Postgres DB in container and it works. It should be fine. We need a Rails 8 support asap

@oliwoodsuk
Copy link

I have tested this locally with the Postgres DB in container and it works. It should be fine. We need a Rails 8 support asap

Yep, same here. All passed.
Going to run off a fork for now

@yupswing
Copy link

Sorry to bother (@remi or anyone else involved) but is there any way this pull request could be published?

Rails 8 is out and this gem is compatible but the gemspec is holding everything back.

Thanks a lot!

@saygun
Copy link

saygun commented Jan 22, 2025

What is blocking this? Is it hard to check out a single PR that has been open for months?

@remi remi merged commit c0380aa into mirego:master Jan 23, 2025
1 check passed
@remi
Copy link
Member

remi commented Jan 23, 2025

Sorry everyone, it was on my todo list for a while and never got to it.

Going to release 3.1.0 version now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants