Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#217 Upgrade commons-compress to version 1.26.1 and upgrade related d… #218

Closed

Conversation

martinstuder
Copy link
Member

…ependencies commons-io and commons-codec; set development version in DESCRIPTION file

…ependencies commons-io and commons-codec; set development version in DESCRIPTION file
@martinstuder
Copy link
Member Author

@spoltier I updated commons-compress to a newer version to what POI depends on and this now (expectedly) fails some hash checks. How do we best deal with this?

@spoltier
Copy link
Member

spoltier commented Mar 11, 2024

You have to align the onLoad function in XLConnect to also download the latest version.

Edit: not sure what you are trying to do. Normally we would have dependabot update xlconnect-java, and that would change the pom.xml ; then we resolve all the depencencies (including transitive) and align onLoad. You seem to have changed onLoad manually, but this is not reflected by anything that is pulled from the pom.xml. Was there an update to POI ? If that is the case I would wait for dependabot to detect it and / or investigate why it has not.

Otherwise we can put commons-compress in the pom.xml explicitly.

@spoltier
Copy link
Member

With the latest POI release, commons-compress has been updated to 1.26.2.

@spoltier spoltier closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants