Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#212 Test loadWorkbook works with relative paths #214

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

martinstuder
Copy link
Member

@martinstuder martinstuder commented Feb 13, 2024

Edit @spoltier:
Closes #212 with code from miraisolutions/xlconnect-java#34

@spoltier spoltier marked this pull request as ready for review February 21, 2024 17:25
Copy link
Member Author

@martinstuder martinstuder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@spoltier spoltier merged commit 3f5fe5f into master Feb 27, 2024
7 checks passed
@spoltier spoltier deleted the bugfix/212_loadWorkbook_relpath branch February 27, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: loadWorkbook fails to open files in XLConnect v1.0.8 if full path is not specified
2 participants