Code

feature/#37-named-by-sheet#146

Code

Closed

spoltier wants to merge 84 commits intomastermiraisolutions/xlconnect:masterfrom feature/#37-named-by-sheetmiraisolutions/xlconnect:feature/#37-named-by-sheetCopy head branch name to clipboard

+939-568

Commits

Commits on Feb 14, 2024

• issue #37: add worksheetName with 'null' default

  spoltier

  committed
  c4458d2

  Copy full SHA for c4458d2

• WIP troubleshooting java xlcall method

  spoltier

  committed
  147afa4

  Copy full SHA for 147afa4

• poi 4.1.0 update dependency jars

  spoltier

  committed
  6e49de8

  Copy full SHA for 6e49de8

• Updated XLConnect jar

  spoltier

  committed
  817ea81

  Copy full SHA for 817ea81

• POI 4.1.0 remove jar in wrong location

  spoltier

  committed
  ebd3c84

  Copy full SHA for ebd3c84

• POI 4.1.0 - java changes recommended in review

  spoltier

  committed
  32d0646

  Copy full SHA for 32d0646

• POI 4.1.0: released xlconnect java

  spoltier

  committed
  a3c6a4f

  Copy full SHA for a3c6a4f

• #37: fix tests, use XLConnect java 1.0.0 + changes

  spoltier

  committed
  f3a2023

  Copy full SHA for f3a2023

• #37 updated xlconnect java

  spoltier

  committed
  dd646dc

  Copy full SHA for dd646dc

• #37: clean up code, add test case

  spoltier

  committed
  c50e79e

  Copy full SHA for c50e79e

• #37 add negative test case

  spoltier

  committed
  8893fd5

  Copy full SHA for 8893fd5

• #37 documentation

  spoltier

  committed
  8f5bc49

  Copy full SHA for 8f5bc49

• #37 fix doc of readNamedRegion

  spoltier

  committed
  0d7b0f1

  Copy full SHA for 0d7b0f1

• gh #37: write in specific sheet's named region

  spoltier

  committed
  370d4a1

  Copy full SHA for 370d4a1

• gh #37: create, check existence, and append to named region + tests

  spoltier

  committed
  a64e35d

  Copy full SHA for a64e35d

• gh #37 clearNamedRegion of specified worksheet

  spoltier

  committed
  3df7ea4

  Copy full SHA for 3df7ea4

• gh #37: add clear Named region test with worksheet name

  spoltier

  committed
  bd69a67

  Copy full SHA for bd69a67

• #37 create name: set worksheet if name provided

  spoltier

  committed
  de8c3c8

  Copy full SHA for de8c3c8

• gh #37: sync jar, dev version

  spoltier

  committed
  129429f

  Copy full SHA for 129429f

• #37 add and clean up doc

  spoltier

  committed
  c50d4bb

  Copy full SHA for c50d4bb

• gh#37 test: formula sheet vs scope sheet

  spoltier

  committed
  6a78164

  Copy full SHA for 6a78164

• gh#37 fix scope v formula - sheet property in java

  spoltier

  committed
  f96293c

  Copy full SHA for f96293c

• #37 fix clearNamedRegion (java), cleanup, clearer doc

  spoltier

  committed
  2c2a72f

  Copy full SHA for 2c2a72f

• gh#37: remove jcenter, seems down

  spoltier

  committed
  7142840

  Copy full SHA for 7142840

• gh #37: test cloning names

  spoltier

  committed
  f2f7ccf

  Copy full SHA for f2f7ccf

• #37 fix cloning names (java)

  spoltier

  committed
  7880cd1

  Copy full SHA for 7880cd1

• #37 match worksheet name strictly (Java)

  spoltier

  committed
  493c642

  Copy full SHA for 493c642

• gh#37 adapt doc to strict matching

  spoltier

  committed
  34f0e7e

  Copy full SHA for 34f0e7e

• #37 correct null check in readNamed...

  spoltier

  committed
  dab4274

  Copy full SHA for dab4274

• Review: null handling / default value

  spoltier

  committed
  c696971

  Copy full SHA for c696971

• Review: parameter name change to '...scope'

  spoltier

  committed
  8759ae0

  Copy full SHA for 8759ae0

• Review: write Named region - WIP?

  spoltier

  committed
  5caf309

  Copy full SHA for 5caf309

• Review: write Named region - doc

  spoltier

  committed
  4f9e4dd

  Copy full SHA for 4f9e4dd

• Review: use "" for explicit global scope

  spoltier

  committed
  a6ae68c

  Copy full SHA for a6ae68c

• Fix doc syntax

  spoltier

  committed
  686defe

  Copy full SHA for 686defe

• Review: worksheet scope for ref coordinates + doc fixes

  spoltier

  committed
  b8d9e0d

  Copy full SHA for b8d9e0d

• Review: scoped removeName, doc fix

  spoltier

  committed
  0527f5b

  Copy full SHA for 0527f5b

• Review: scoped addImage, missing default

  spoltier

  committed
  1c50801

  Copy full SHA for 1c50801

• Review - fix doc

  spoltier

  committed
  e3237f1

  Copy full SHA for e3237f1

• Review: addImage backwards compat

  spoltier

  committed
  1558570

  Copy full SHA for 1558570

• addImage fix doc

  spoltier

  committed
  9dd0c09

  Copy full SHA for 9dd0c09

• review: dimension-abiding readNamedRegion

  spoltier

  committed
  7a00557

  Copy full SHA for 7a00557

• Restore full clear named region check

  spoltier

  committed
  aacf7f5

  Copy full SHA for aacf7f5

• Test write named to file with scope vector

  spoltier

  committed
  54a3d1e

  Copy full SHA for 54a3d1e

• Proposed fix, test change, fix read test

  spoltier

  committed
  79a13ce

  Copy full SHA for 79a13ce

• Fixed test

  spoltier

  committed
  c29519b

  Copy full SHA for c29519b

• attributes (handling new java cls, setting attrs)

  spoltier

  committed
  d8fcf1f

  Copy full SHA for d8fcf1f

• processing attributes, working for n scopes

  spoltier

  committed
  1328086

  Copy full SHA for 1328086

• jar - handle null scope in create

  spoltier

  committed
  1760476

  Copy full SHA for 1760476

• Adapted attribute handling with suggested approach

  spoltier

  committed
  8f3333a

  Copy full SHA for 8f3333a

• correctly set names

  spoltier

  committed
  f15bbac

  Copy full SHA for f15bbac

• clean up, ws scope attribute when null (jar)

  spoltier

  committed
  f4d7634

  Copy full SHA for f4d7634

• WIP read named region attributes

  spoltier

  committed
  4369e7a

  Copy full SHA for 4369e7a

• note after discussing with Riccardo

  spoltier

  committed
  4976fcf

  Copy full SHA for 4976fcf

• attribute value is array of string

  spoltier

  committed
  9ada0e4

  Copy full SHA for 9ada0e4

• Attributes in dataframe from java

  spoltier

  committed
  078a8d9

  Copy full SHA for 078a8d9

• preserve attributes in extractRowNames

  spoltier

  committed
  fcf1e76

  Copy full SHA for fcf1e76

• use xlconnect-java rebased - with overwriteFormulaCells

  spoltier

  committed
  5779918

  Copy full SHA for 5779918

• Jar from rebased XLConnect-java (refactoring)

  spoltier

  committed
  97498c1

  Copy full SHA for 97498c1

• align xlcWithAttr... with changes to xlcCall

  spoltier

  committed
  6a178a5

  Copy full SHA for 6a178a5

• avoid overwriting names when setting attributes

  spoltier

  committed
  00df658

  Copy full SHA for 00df658

• checkTrue instead of checkExists for bool with attributes

  spoltier

  committed
  1db8cba

  Copy full SHA for 1db8cba

• test write named region using (supported) scalar formula values only

  spoltier

  committed
  fcd8897

  Copy full SHA for fcd8897

• Doc: fix argument order in writeNamedRegionToFile

  spoltier

  committed
  a05c770

  Copy full SHA for a05c770

• combined version of xlcCall + Attributes

  spoltier

  committed
  30e38f2

  Copy full SHA for 30e38f2

• test that attributes are set on existsName

  spoltier

  committed
  b44ce4a

  Copy full SHA for b44ce4a

• test creating scoped names

  spoltier

  committed
  93492aa

  Copy full SHA for 93492aa

• remove unused code, reorder lines for clarity

  spoltier

  committed
  58f0d80

  Copy full SHA for 58f0d80

• define and test attributes toggle

  spoltier

  committed
  0e40b0e

  Copy full SHA for 0e40b0e

• implement attributes toggle

  spoltier

  committed
  2daff5c

  Copy full SHA for 2daff5c

• add scope param and clarify attribute handling in documentation

  spoltier

  committed
  4d28850

  Copy full SHA for 4d28850

• writeNamedRegionToFile: handle len(formula)>1

  spoltier

  committed
  322832d

  Copy full SHA for 322832d

• refactoring: align function param order

  spoltier

  committed
  35f1274

  Copy full SHA for 35f1274

• missing in \usage of appendNamedRegion-methods

  spoltier

  committed
  280a30d

  Copy full SHA for 280a30d

• troubleshooting LaTeX output on newer R versions (?)

  spoltier

  committed
  73a28e0

  Copy full SHA for 73a28e0

• fix itemize syntax

  spoltier

  committed
  3ddafb9

  Copy full SHA for 3ddafb9

• line break not required

  spoltier

  committed
  4fe092d

  Copy full SHA for 4fe092d

• test presence attributes on dataframes

  spoltier

  committed
  2dd5884

  Copy full SHA for 2dd5884

• preserve java attributes on dataframes

  spoltier

  committed
  a225f68

  Copy full SHA for a225f68

• test: write then read two dataframes at once

  spoltier

  committed
  6a3f263

  Copy full SHA for 6a3f263

• xlc-java candidate snapshot (refactored, no API changes)

  spoltier

  committed
  c22bf90

  Copy full SHA for c22bf90

• clean up debug statements

  spoltier

  committed
  74f6967

  Copy full SHA for 74f6967

• jar from CI build

  spoltier

  committed
  4d9c7bb

  Copy full SHA for 4d9c7bb

• clean up old jar after rebase

  spoltier

  committed
  8e5a71b

  Copy full SHA for 8e5a71b