return attributes for getReferenceCoordinatesForName

miraisolutions · Apr 9, 2024 · f751802 · f751802
1 parent b629435
commit f751802
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/R/workbook.getReferenceCoordinates.R b/R/workbook.getReferenceCoordinates.R
@@ -33,7 +33,7 @@ setMethod("getReferenceCoordinates",
 		signature(object = "workbook"), 
 		function(object, name) {
       .Deprecated("getReferenceCoordinatesForName")
-			res <- xlcCall(object, "getReferenceCoordinatesForName", name)
+			res <- xlcCall(object, "getReferenceCoordinatesForName", name, .withAttributes = TRUE)
       if(is.numeric(res)) { matrix(res, nrow = 2, byrow = TRUE) + 1 } else { res } 
 		}
 )
diff --git a/R/workbook.getReferenceCoordinatesForName.R b/R/workbook.getReferenceCoordinatesForName.R
@@ -32,7 +32,7 @@ setGeneric("getReferenceCoordinatesForName",
 setMethod("getReferenceCoordinatesForName", 
 		signature(object = "workbook"), 
 		function(object, name, worksheetScope = NULL) {
-			res <- xlcCall(object, "getReferenceCoordinatesForName", name, worksheetScope %||% .jnull())
+			res <- xlcCall(object, "getReferenceCoordinatesForName", name, worksheetScope %||% .jnull(), .withAttributes = TRUE) # TODO with Attributes!
       		if(is.numeric(res)) { matrix(res, nrow = 2, byrow = TRUE) + 1 } else { res } 
 		}
 )
diff --git a/inst/java/XLConnect-3.0.0-SNAPSHOT.jar b/inst/java/XLConnect-3.0.0-SNAPSHOT.jar