Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shinydashboardPlus dependency #113

Closed
riccardoporreca opened this issue Mar 27, 2019 · 1 comment
Closed

Remove shinydashboardPlus dependency #113

riccardoporreca opened this issue Mar 27, 2019 · 1 comment
Assignees

Comments

@riccardoporreca
Copy link
Member

riccardoporreca commented Mar 27, 2019

SmaRP depends on package shinydashboardPlus for the sole collapsible panels provided by shinydashboardPlus::boxPlus().

Our current dependency on shinydashboardPlus poses the following undesired issues:

The suggestion is to get rid of shinydashboardPlus alltoghether by replacing boxPlus() with small custom code for creating HTML panels and adding collapsing functionality from the existing dependency package bsplus.

riccardoporreca added a commit that referenced this issue Apr 3, 2019
* To be documented, standalone example exists under man-roxygen.
* Removed shinydashboardPlus dependency, tooltips to be reviewd after removal.
* Consolidated all JS in UI's head.
@riccardoporreca
Copy link
Member Author

riccardoporreca commented Apr 3, 2019

New custom SmaRPanel() replacing shinydashboardPlus::boxPlus() implemented in
419b158 (including removal of shinydashboardPlus package dependency). The replacement can be assessed in the app itself or in the standalone example man-roxygen/ex-SmaRPanel.R

TODOs

@riccardoporreca riccardoporreca self-assigned this Apr 3, 2019
riccardoporreca added a commit that referenced this issue Apr 3, 2019
* Produces the same tooltips as with the former shinydashboardPlus.
riccardoporreca added a commit that referenced this issue Apr 3, 2019
* Support no title in collapsible panels via min-height, included in example.
riccardoporreca added a commit that referenced this issue Apr 4, 2019
riccardoporreca added a commit that referenced this issue May 20, 2019
* Formerly needed only for shinyWidgets::useShinydashboardPlus().
@gabrielfoix gabrielfoix added this to the Next release milestone Jul 9, 2019
RolandASc pushed a commit that referenced this issue Jul 22, 2019
* To be documented, standalone example exists under man-roxygen.
* Removed shinydashboardPlus dependency, tooltips to be reviewd after removal.
* Consolidated all JS in UI's head.
RolandASc pushed a commit that referenced this issue Jul 22, 2019
* Produces the same tooltips as with the former shinydashboardPlus.
RolandASc pushed a commit that referenced this issue Jul 22, 2019
* Support no title in collapsible panels via min-height, included in example.
RolandASc pushed a commit that referenced this issue Jul 22, 2019
RolandASc pushed a commit that referenced this issue Jul 22, 2019
* Formerly needed only for shinyWidgets::useShinydashboardPlus().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants