Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: miracle can now integrate with systemd in a meaningful way #228

Merged
merged 13 commits into from
Sep 7, 2024
Merged

feature: miracle can now integrate with systemd in a meaningful way #228

merged 13 commits into from
Sep 7, 2024

Conversation

mattkae
Copy link
Collaborator

@mattkae mattkae commented Sep 4, 2024 •
edited
Loading

What's new?

  • Added instructions for running miracle-wm with systemd session integration
  • Added the -DSYSTEMD_INTEGRATION build option
  • miracle-wm no longer starts directly, but rather with a miracle-wm-session script (this will need more work in the future, but this is a good start)
  • miracle-wm will write to journal if it can from the default runner script
  • miracle-wm now handles shutdown events

Conan-Kudo
Conan-Kudo requested changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@Conan-Kudo Conan-Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, just a couple of things...

session/README.md Show resolved Hide resolved
session/usr/bin/libexec/miracle-wm/session.sh Outdated Show resolved Hide resolved
@mecattaf mecattaf mentioned this pull request Sep 5, 2024
Closed
@Conan-Kudo
Copy link
Collaborator

From @alebastr in Matrix:

since you don't have the same constraints as me, you can move parts of the session.sh to miracle-wm-session. The only things that really need to be delayed until the compositor is ready are:

  • exporting variables set by the compositor: DISPLAY, WAYLAND_DISPLAY, SWAYSOCK
  • starting the session target

Even session-shutdown.target can be invoked after the compositor exits.

Conan-Kudo
Conan-Kudo reviewed Sep 5, 2024
View reviewed changes
session/README.md Outdated Show resolved Hide resolved
@Conan-Kudo
Copy link
Collaborator

Nope, put that Xwayland fix in a separate PR. 😛

@mattkae
Copy link
Collaborator Author

mattkae commented Sep 5, 2024

You caught me :( #237

Conan-Kudo
Conan-Kudo requested changes Sep 5, 2024
View reviewed changes
session/usr/bin/libexec/miracle-wm/session.sh Outdated Show resolved Hide resolved
session/usr/bin/libexec/miracle-wm/session.sh Outdated Show resolved Hide resolved
Conan-Kudo
Conan-Kudo requested changes Sep 5, 2024
View reviewed changes
session/README.md Outdated Show resolved Hide resolved
Conan-Kudo
Conan-Kudo requested changes Sep 7, 2024
View reviewed changes
session/README.md Outdated Show resolved Hide resolved
Conan-Kudo
Conan-Kudo approved these changes Sep 7, 2024
View reviewed changes
Copy link
Collaborator

@Conan-Kudo Conan-Kudo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're finally good to go.

@Conan-Kudo Conan-Kudo enabled auto-merge (squash) September 7, 2024 13:07
@Conan-Kudo Conan-Kudo merged commit 690da3a into develop Sep 7, 2024
2 checks passed
@Conan-Kudo Conan-Kudo deleted the feature/user_session branch September 7, 2024 13:07
mattkae added a commit that referenced this pull request Sep 7, 2024
@mattkae
feature: miracle can now integrate with systemd in a meaningful way (#…
639e4e1 
…228)

Miracle now supports running through systemd, including logging to the
journal and invoking processes as transient units through systemd-run.

This is controlled as a build-time feature in CMake.
@Conan-Kudo Conan-Kudo mentioned this pull request Oct 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Conan-Kudo Conan-Kudo Conan-Kudo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattkae @Conan-Kudo