Release Album Assignment Change #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only an "Album" or "ClassicalAlbum" could be assigned to ddexReleaseAlbum within the SimpleAlbum class. As per the Release Type List ( https://kb.ddex.net/display/dsrf30avs/5.5+ReleaseType ), that does not cover all instances of music. At a minimum you would need Album, ClassicalAlbum and Single, however you also have to handle userDefined values too. Given that DDEX state ( https://kb.ddex.net/display/HBK/Release+Types+for+TrackReleases ) that track releases must use TrackRelease on tracks within a release, it makes slightly more sense to flip the logic and apply the release status to the Release that is not TrackRelease. Added a small test for UserDefined EP and all tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only an "Album" or "ClassicalAlbum" could be assigned to ddexReleaseAlbum within the SimpleAlbum class.
As per the Release Type List (https://kb.ddex.net/display/dsrf30avs/5.5+ReleaseType), that does not cover all instances of music.
At a minimum you would need Album, ClassicalAlbum and Single, however you also have to handle userDefined values too.
Given that DDEX state (https://kb.ddex.net/display/HBK/Release+Types+for+TrackReleases) that track releases must use TrackRelease on tracks within a release, it makes slightly more sense to flip the logic and apply the release status to the Release that is not TrackRelease.
Added a small test for UserDefined EP and all tests pass.