[Core] Remove unused sync gcs client in dashboard agent (ray-project#…

…41899) We are only using async gcs client. Signed-off-by: Jiajun Yao <[email protected]>
miqdigital · Dec 15, 2023 · 8e45283 · 8e45283
1 parent 7e679fd
commit 8e45283
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 18 deletions.
diff --git a/dashboard/agent.py b/dashboard/agent.py
@@ -14,17 +14,12 @@
 import ray._private.utils
 import ray.dashboard.consts as dashboard_consts
 import ray.dashboard.utils as dashboard_utils
-from ray._raylet import GcsClient
 from ray._private.process_watcher import create_check_raylet_task
 from ray._private.gcs_utils import GcsAioClient
 from ray._private.ray_logging import (
     setup_component_logger,
     configure_log_file,
 )
-from ray.experimental.internal_kv import (
-    _initialize_internal_kv,
-    _internal_kv_initialized,
-)
 from ray._private.ray_constants import AGENT_GRPC_MAX_MESSAGE_LENGTH
 
 logger = logging.getLogger(__name__)
@@ -80,11 +75,6 @@ def __init__(
         self.http_server = None
 
         # Used by the agent and sub-modules.
-        # TODO(architkulkarni): Remove gcs_client once the agent exclusively uses
-        # gcs_aio_client and not gcs_client.
-        self.gcs_client = GcsClient(address=self.gcs_address)
-        _initialize_internal_kv(self.gcs_client)
-        assert _internal_kv_initialized()
         self.gcs_aio_client = GcsAioClient(
             address=self.gcs_address,
             nums_reconnect_retry=ray._config.gcs_rpc_server_reconnect_timeout_s(),

diff --git a/dashboard/modules/job/common.py b/dashboard/modules/job/common.py
@@ -9,9 +9,6 @@
 from ray._private import ray_constants
 from ray._private.gcs_utils import GcsAioClient
 from ray._private.runtime_env.packaging import parse_uri
-from ray.experimental.internal_kv import (
-    _internal_kv_initialized,
-)
 
 from ray.util.annotations import PublicAPI
 
@@ -195,7 +192,6 @@ class JobInfoStorageClient:
 
     def __init__(self, gcs_aio_client: GcsAioClient):
         self._gcs_aio_client = gcs_aio_client
-        assert _internal_kv_initialized()
 
     async def put_info(
         self, job_id: str, job_info: JobInfo, overwrite: bool = True

diff --git a/python/ray/_private/gcs_aio_client.py b/python/ray/_private/gcs_aio_client.py
@@ -66,12 +66,8 @@ def __init__(
             nums_reconnect_retry,
         )
         self._async_proxy = AsyncProxy(self._gcs_client, loop, executor)
-        self._connect()
         self._nums_reconnect_retry = nums_reconnect_retry
 
-    def _connect(self):
-        self._gcs_client._connect()
-
     @property
     def address(self):
         return self._gcs_client.address