Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fieldValueMatches / fieldValueNotMatches #775

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

das-peter
Copy link

Would be hand to allow pattern assertions on field values like on the page text.
This was mentioned here #696 but: "PR got lost in the sands of time" :)

Copy link
Member

@aik099 aik099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add tests.

Squash:
* Added tests.
* Fixed inversion of condition.
* Add fieldValueMatches / fieldValueNotMatches

Would be hand to allow pattern assertions on field values like on the page text.
This was mentioned here minkphp#696 but: "PR got lost in the sands of time" :)
@das-peter
Copy link
Author

das-peter commented Jun 2, 2019

Added tests, based on testPageTextMatches / testPageTextNotMatches / testFieldValueEquals / testFieldValueNotEquals.

Edit: Commits have been squashed.

@aik099
Copy link
Member

aik099 commented Jun 3, 2019

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants