Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix U21 matches not being recognised for xp calc #1730

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

unnecessarydave
Copy link
Contributor

The updated code in function getGameType wasn't catching U21 continental cup matches. Adding the relevant icon names to the CONT_CUPS list fixes this.

@cpf-fin
Copy link

cpf-fin commented Mar 25, 2024

Similar tests are "reversed", does gameIcon.includes(CONT_CUPS) work? (no need to change CONT_CUPS)

@unnecessarydave
Copy link
Contributor Author

unnecessarydave commented Mar 25, 2024

Similar tests are "reversed", does gameIcon.includes(CONT_CUPS) work? (no need to change CONT_CUPS)

Sure, we could do it that way.

gameIcon.includes(CONT_CUPS) alone doesn't work, as I think .includes() takes a search string, not an array. But, we could loop through the array, which I admit is better.

I'll see if I can figure out how update the PR.

The updated code in function getNTType() wasn't catching U21 continental cup
matches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants