Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPAL-1231 take apk upgrade out of api dockerfile. #1571

Closed
wants to merge 5 commits into from

Conversation

nickdavis2001
Copy link
Contributor

@nickdavis2001 nickdavis2001 commented Jul 24, 2023

same time

Purpose

_Remove the apk upgrade from Dockerfile for api because this is leading to unwanted upgrades that cause performance problems. Meanwhile change the aws keys for locally running dynamodb from hyphen which is not longer allowed, to devkey. Note - we ought to do a similar removal of apk upgrade in the service-front in future, but , on a seperate PR _

Approach

Update Dockerfile and docker-compose.yml

Checklist

  • I have performed a self-review of my own code
  • I have updated documentation (Confluence/GitHub wiki/tech debt doc) where relevant
  • I have added tests to prove my work
  • I have added mandatory tags to terraformed resources, where possible
  • If I have a new OPG component dependency, I have updated the metadata.json with the repo location.
  • If I added a package.json or composer.json, I also made sure this is included in the script in .github/workflows/dependabot-update.yml
  • The product team have tested these changes

@nickdavis2001 nickdavis2001 requested a review from a team as a code owner July 24, 2023 14:51
ntse
ntse previously approved these changes Jul 24, 2023
@nickdavis2001 nickdavis2001 temporarily deployed to dev_1571lpal123 July 24, 2023 16:28 — with GitHub Actions Inactive
@nickdavis2001
Copy link
Contributor Author

Superseded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants