fix: maintain require()
compatibility for filters
#1256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses an issue raised on Slack
I've added a workaround to keep the
moj/filters/all
export working whilst we look at:Module resolution
For example, Node.js can't resolve
moj/filters/all
node --eval "console.log(require.resolve('@ministryofjustice/frontend/moj/filters/all'))"
But it can resolve
moj/filters/all.js
node --eval "console.log(require.resolve('@ministryofjustice/frontend/moj/filters/all.js'))"
This is caused by both Package entry point
"exports"
in package.json and Node.js mandatory file extensionsOutdated examples
Both of these examples will need updating in #1249
moj-frontend/src/moj/components/messages/README.md
Line 11 in a909349
moj-frontend/src/moj/components/timeline/README.md
Line 11 in a909349