build: consolidate Sass and JavaScript tasks #1169

colinrotherham · 2025-02-21T08:55:21Z

This PR creates 2x new shared tasks compileStyles() and compileScripts()

It also removes various unnecessary Gulp packages:

gulp-postcss
gulp-rename
gulp-sass

Fixes #927 and (probably) supersedes:

gregtyler · 2025-02-25T11:34:51Z

🎉 This PR is included in version 3.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

colinrotherham requested a review from a team as a code owner February 21, 2025 08:55

colinrotherham force-pushed the gulp-shared branch from 21c9d94 to c67ff24 Compare February 21, 2025 09:38

colinrotherham force-pushed the terser-minify branch 2 times, most recently from f178ffe to e9aebf7 Compare February 21, 2025 11:29

colinrotherham force-pushed the gulp-shared branch 3 times, most recently from 9f84785 to 18a96e4 Compare February 21, 2025 12:25

colinrotherham force-pushed the terser-minify branch from e9aebf7 to f80acf9 Compare February 24, 2025 13:11

colinrotherham force-pushed the gulp-shared branch from 18a96e4 to bacac40 Compare February 24, 2025 13:12

chrispymm approved these changes Feb 24, 2025

View reviewed changes

colinrotherham force-pushed the terser-minify branch from f80acf9 to 313022c Compare February 24, 2025 19:24

colinrotherham force-pushed the gulp-shared branch from bacac40 to 0e1c0fa Compare February 24, 2025 19:24

colinrotherham force-pushed the terser-minify branch from 313022c to a1f7993 Compare February 25, 2025 07:59

Base automatically changed from terser-minify to main February 25, 2025 08:05

colinrotherham force-pushed the gulp-shared branch from 0e1c0fa to fc672fd Compare February 25, 2025 08:06

colinrotherham added 6 commits February 25, 2025 08:59

build: split out Gulp Sass task

48ce1b8

build: split out Gulp JavaScript task

b81de50

build: run Sass task without Gulp

cd1c809

chore: add silenced deprecations from Gulp plugin

42cb778

chore: resolve @ministryofjustice/frontend internally

348f6b7

chore: remove node_modules from all import paths

ff47cf4

colinrotherham force-pushed the gulp-shared branch from fc672fd to ff47cf4 Compare February 25, 2025 09:01

colinrotherham added 3 commits February 25, 2025 11:19

ci: drop eol node versions from testing matrix

2ff980e

ci: run checks on all pull requests

de4e1e3

ci: allow manual checks on branches

15cf9ea

colinrotherham force-pushed the gulp-shared branch from 8ee2d32 to 15cf9ea Compare February 25, 2025 11:21

colinrotherham merged commit 40f7047 into main Feb 25, 2025
16 checks passed

colinrotherham deleted the gulp-shared branch February 25, 2025 11:26

gregtyler added the released label Feb 25, 2025

Provide feedback