Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story/ccls 2159 case outcome #35

Merged
merged 12 commits into from
May 14, 2024
Original file line number Diff line number Diff line change
@@ -2,6 +2,7 @@

import jakarta.persistence.AttributeConverter;
import java.util.Arrays;
import java.util.Optional;
import java.util.stream.Stream;
import org.hibernate.dialect.Dialect;
import org.hibernate.type.descriptor.converter.spi.BasicValueConverter;
@@ -71,9 +72,18 @@ public Boolean toDomainValue(String relationalForm) {
return null;
}

return Arrays.asList(trueValues).contains(relationalForm)
? Boolean.TRUE :
(Arrays.asList(falseValues).contains(relationalForm) ? Boolean.FALSE : null);
return containsRelationalForm(trueValues, relationalForm, Boolean.TRUE)
.orElseGet(() -> containsRelationalForm(falseValues, relationalForm, Boolean.FALSE)
.orElseThrow(() -> new RuntimeException(
String.format("Unknown boolean relational value %s", relationalForm))));
}

private Optional<Boolean> containsRelationalForm(final String[] values,
final String relationalForm, final Boolean response) {
return Arrays.stream(values)
.filter(s -> s.equals(relationalForm))
.findFirst()
.map(s -> response);
}

/**
Original file line number Diff line number Diff line change
@@ -3,9 +3,11 @@
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertNull;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;

import java.util.Arrays;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.CsvSource;

@@ -26,8 +28,23 @@ void testToDomainValue_returnsCorrectResponse(String trueValues, String falseVal

Arrays.stream(trueVals).forEach(s -> assertTrue(booleanStringConverter.toDomainValue(s)));
Arrays.stream(falseVals).forEach(s -> assertFalse(booleanStringConverter.toDomainValue(s)));
assertNull(booleanStringConverter.toDomainValue("unknownval"));
assertNull(booleanStringConverter.toDomainValue(null));
}

@Test
void testToDomainValue_nullValue_returnsNull() {
BooleanStringConverter booleanStringConverter = new BooleanStringConverter(
new String[]{"Y"}, new String[]{"N"});

assertThrows( RuntimeException.class, () -> booleanStringConverter.toDomainValue(
"unknownval"));
}

@Test
void testToDomainValue_unknownValue_throwsException() {
BooleanStringConverter booleanStringConverter = new BooleanStringConverter(
new String[]{"Y"}, new String[]{"N"});

assertNull( booleanStringConverter.toDomainValue(null));
}

@ParameterizedTest