Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 moving EKS subnets out of VPC module #3368

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

kyphutruong
Copy link
Contributor

This PR moves the EKS-Private subnets out of the VPC module. Reasons explained in this issue

The subnets resources have already been manually moved using the following commands prior to this PR:

terraform state mv 'module.vpc.aws_subnet.private[3]' 'aws_subnet.eks_private[0]'
terraform state mv 'module.vpc.aws_subnet.private[4]' 'aws_subnet.eks_private[1]'
terraform state mv 'module.vpc.aws_subnet.private[5]' 'aws_subnet.eks_private[2]'
terraform state mv 'module.vpc.aws_route_table_association.private[3]' 'aws_route_table_association.eks_private[0]'
terraform state mv 'module.vpc.aws_route_table_association.private[4]' 'aws_route_table_association.eks_private[1]'
terraform state mv 'module.vpc.aws_route_table_association.private[5]' 'aws_route_table_association.eks_private[2]'

Tf plans should output No changes. Your infrastructure matches the configuration.

@kyphutruong kyphutruong requested a review from a team as a code owner September 20, 2024 10:19
@kyphutruong kyphutruong merged commit 0f01b55 into main Sep 20, 2024
0 of 2 checks passed
@kyphutruong kyphutruong deleted the move-eks-subnets-out-vpc-module branch September 20, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants