-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESWE-1234 add DPR security gp and configure param groups on dev
#29856
Conversation
Terraform Plan SummaryTerraform Plan: 0 to be created, 0 to be destroyed, 2 to be updated, 0 to be replaced and 30 unchanged.Resources to update:! module.rds.aws_db_instance.rds
! module.rds.aws_db_parameter_group.custom_parameters |
This PR CANNOT be auto approved and requires manual approval from the Cloud Platform team. |
.../live.cloud-platform.service.justice.gov.uk/hmpps-jobs-board-dev/resources/rds-postgresql.tf
Outdated
Show resolved
Hide resolved
Terraform Plan SummaryTerraform Plan: 0 to be created, 0 to be destroyed, 1 to be updated, 0 to be replaced and 31 unchanged.Resources to update:! module.rds.aws_db_parameter_group.custom_parameters |
This PR CANNOT be auto approved and requires manual approval from the Cloud Platform team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the confusing comment, thanks.
.../live.cloud-platform.service.justice.gov.uk/hmpps-jobs-board-dev/resources/rds-postgresql.tf
Outdated
Show resolved
Hide resolved
Terraform Plan SummaryTerraform Plan: 0 to be created, 0 to be destroyed, 2 to be updated, 0 to be replaced and 30 unchanged.Resources to update:! module.rds.aws_db_instance.rds
! module.rds.aws_db_parameter_group.custom_parameters |
This PR CANNOT be auto approved and requires manual approval from the Cloud Platform team. |
Terraform Plan SummaryTerraform Plan: 0 to be created, 0 to be destroyed, 2 to be updated, 0 to be replaced and 30 unchanged.Resources to update:! module.rds.aws_db_instance.rds
! module.rds.aws_db_parameter_group.custom_parameters |
This PR CANNOT be auto approved and requires manual approval from the Cloud Platform team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The max_slot_wal_keep_size is smaller than DPR guide, but still look sufficient for the tiny dev DB.
We need to follow the same size as in the guide in other env (preprod, `prod) DB later.
dev
Terraform Plan SummaryTerraform Plan: 0 to be created, 0 to be destroyed, 2 to be updated, 0 to be replaced and 30 unchanged.Resources to update:! module.rds.aws_db_instance.rds
! module.rds.aws_db_parameter_group.custom_parameters |
This PR CANNOT be auto approved and requires manual approval from the Cloud Platform team. |
No description provided.