Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESWE-1234 add DPR security gp and configure param groups on dev #29856

Merged
merged 10 commits into from
Feb 21, 2025

Conversation

gbmojo
Copy link
Contributor

@gbmojo gbmojo commented Feb 19, 2025

No description provided.

@gbmojo gbmojo requested a review from a team as a code owner February 19, 2025 17:18
@gbmojo gbmojo changed the title Eswe 1234 configure param groups dpr ESWE-1234 configure param groups dpr Feb 19, 2025
@sablumiah
Copy link
Contributor

Terraform Plan Summary

Terraform Plan: 0 to be created, 0 to be destroyed, 2 to be updated, 0 to be replaced and 30 unchanged.

Resources to update:

! module.rds.aws_db_instance.rds
! module.rds.aws_db_parameter_group.custom_parameters

@sablumiah
Copy link
Contributor

This PR CANNOT be auto approved and requires manual approval from the Cloud Platform team.
Reason:
🕵️‍♂️ Manual review required: OPA auto approve policy checks did not pass.
Please raise it in #ask-cloud-platform Slack channel.

@sablumiah
Copy link
Contributor

Terraform Plan Summary

Terraform Plan: 0 to be created, 0 to be destroyed, 1 to be updated, 0 to be replaced and 31 unchanged.

Resources to update:

! module.rds.aws_db_parameter_group.custom_parameters

@sablumiah
Copy link
Contributor

This PR CANNOT be auto approved and requires manual approval from the Cloud Platform team.
Reason:
🕵️‍♂️ Manual review required: OPA auto approve policy checks did not pass.
Please raise it in #ask-cloud-platform Slack channel.

Copy link
Contributor

@rickchoijd rickchoijd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the confusing comment, thanks.

@gbmojo gbmojo changed the title ESWE-1234 configure param groups dpr ESWE-1234 add DPR security gp and configure param groups Feb 20, 2025
@sablumiah
Copy link
Contributor

Terraform Plan Summary

Terraform Plan: 0 to be created, 0 to be destroyed, 2 to be updated, 0 to be replaced and 30 unchanged.

Resources to update:

! module.rds.aws_db_instance.rds
! module.rds.aws_db_parameter_group.custom_parameters

@sablumiah
Copy link
Contributor

This PR CANNOT be auto approved and requires manual approval from the Cloud Platform team.
Reason:
🕵️‍♂️ Manual review required: OPA auto approve policy checks did not pass.
Please raise it in #ask-cloud-platform Slack channel.

@sablumiah
Copy link
Contributor

Terraform Plan Summary

Terraform Plan: 0 to be created, 0 to be destroyed, 2 to be updated, 0 to be replaced and 30 unchanged.

Resources to update:

! module.rds.aws_db_instance.rds
! module.rds.aws_db_parameter_group.custom_parameters

@sablumiah
Copy link
Contributor

This PR CANNOT be auto approved and requires manual approval from the Cloud Platform team.
Reason:
🕵️‍♂️ Manual review required: OPA auto approve policy checks did not pass.
Please raise it in #ask-cloud-platform Slack channel.

rickchoijd
rickchoijd previously approved these changes Feb 21, 2025
Copy link
Contributor

@rickchoijd rickchoijd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The max_slot_wal_keep_size is smaller than DPR guide, but still look sufficient for the tiny dev DB.
We need to follow the same size as in the guide in other env (preprod, `prod) DB later.

@rickchoijd rickchoijd changed the title ESWE-1234 add DPR security gp and configure param groups ESWE-1234 add DPR security gp and configure param groups on dev Feb 21, 2025
@sablumiah
Copy link
Contributor

Terraform Plan Summary

Terraform Plan: 0 to be created, 0 to be destroyed, 2 to be updated, 0 to be replaced and 30 unchanged.

Resources to update:

! module.rds.aws_db_instance.rds
! module.rds.aws_db_parameter_group.custom_parameters

@sablumiah
Copy link
Contributor

This PR CANNOT be auto approved and requires manual approval from the Cloud Platform team.
Reason:
🕵️‍♂️ Manual review required: OPA auto approve policy checks did not pass.
Please raise it in #ask-cloud-platform Slack channel.

@gbmojo gbmojo merged commit 8b237de into main Feb 21, 2025
14 checks passed
@gbmojo gbmojo deleted the eswe-1234-configure-param-groups-dpr branch February 21, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants