Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscription to domain events for hmpps-community-accommodation-prod #29215

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

besscerule
Copy link
Contributor

No description provided.

@besscerule besscerule self-assigned this Jan 29, 2025
@besscerule besscerule requested a review from a team as a code owner January 29, 2025 15:53
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

@sablumiah
Copy link
Contributor

Terraform Plan Summary

Terraform Plan: 11 to be created, 0 to be destroyed, 0 to be updated, 1 to be replaced and 45 unchanged.

Resources to create:

+ aws_sns_topic_subscription.cas-2-domain-events-queue-subscription
+ aws_sqs_queue_policy.cas-2-domain-events-dlq-policy
+ aws_sqs_queue_policy.cas-2-domain-events-queue-policy
+ kubernetes_secret.cas-2-domain-events-dlq-secret
+ kubernetes_secret.cas-2-domain-events-queue-secret
+ module.cas-2-domain-events-dlq.aws_iam_policy.irsa
+ module.cas-2-domain-events-dlq.aws_sqs_queue.terraform_queue
+ module.cas-2-domain-events-dlq.random_id.id
+ module.cas-2-domain-events-queue.aws_iam_policy.irsa
+ module.cas-2-domain-events-queue.aws_sqs_queue.terraform_queue
+ module.cas-2-domain-events-queue.random_id.id

Resources to replace:

-+ module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["rds"]

@sablumiah
Copy link
Contributor

This PR requires approval from the Cloud Platform team.
Reason: OPA auto approval policy check failed.
Please raise it in #ask-cloud-platform Slack channel.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

@sablumiah
Copy link
Contributor

Terraform Plan Summary

Terraform Plan: 11 to be created, 0 to be destroyed, 0 to be updated, 1 to be replaced and 45 unchanged.

Resources to create:

+ aws_sns_topic_subscription.cas-2-domain-events-queue-subscription
+ aws_sqs_queue_policy.cas-2-domain-events-dlq-policy
+ aws_sqs_queue_policy.cas-2-domain-events-queue-policy
+ kubernetes_secret.cas-2-domain-events-dlq-secret
+ kubernetes_secret.cas-2-domain-events-queue-secret
+ module.cas-2-domain-events-dlq.aws_iam_policy.irsa
+ module.cas-2-domain-events-dlq.aws_sqs_queue.terraform_queue
+ module.cas-2-domain-events-dlq.random_id.id
+ module.cas-2-domain-events-queue.aws_iam_policy.irsa
+ module.cas-2-domain-events-queue.aws_sqs_queue.terraform_queue
+ module.cas-2-domain-events-queue.random_id.id

Resources to replace:

-+ module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["rds"]

@sablumiah
Copy link
Contributor

This PR requires approval from the Cloud Platform team.
Reason: OPA auto approval policy check failed.
Please raise it in #ask-cloud-platform Slack channel.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

@sablumiah
Copy link
Contributor

Terraform Plan Summary

Terraform Plan: 16 to be created, 5 to be destroyed, 0 to be updated, 0 to be replaced and 41 unchanged.

Resources to create:

+ aws_sns_topic_subscription.cas-2-domain-events-queue-subscription
+ aws_sqs_queue_policy.cas-2-domain-events-dlq-policy
+ aws_sqs_queue_policy.cas-2-domain-events-queue-policy
+ kubernetes_secret.cas-2-domain-events-dlq-secret
+ kubernetes_secret.cas-2-domain-events-queue-secret
+ module.cas-2-domain-events-dlq.aws_iam_policy.irsa
+ module.cas-2-domain-events-dlq.aws_sqs_queue.terraform_queue
+ module.cas-2-domain-events-dlq.random_id.id
+ module.cas-2-domain-events-queue.aws_iam_policy.irsa
+ module.cas-2-domain-events-queue.aws_sqs_queue.terraform_queue
+ module.cas-2-domain-events-queue.random_id.id
+ module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["cas-2-sns"]
+ module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["domain_events_topic"]
+ module.irsa_ap.module.iam_assumable_role.aws_iam_role_policy_attachment.this["audit_sqs"]
+ module.irsa_cas2.module.iam_assumable_role.aws_iam_role_policy_attachment.this["audit_sqs"]
+ module.irsa_ta.module.iam_assumable_role.aws_iam_role_policy_attachment.this["audit_sqs"]

Resources to destroy:

- module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["/hmpps-domain-events-prod/sns/cloud-platform-Digital-Prison-Services-97e6567cf80881a8a52290ff2c269b08/irsa-policy-arn"]
- module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["rds"]
- module.irsa_ap.module.iam_assumable_role.aws_iam_role_policy_attachment.this["/hmpps-audit-prod/sqs/Digital-Prison-Services-prod-hmpps_audit_queue/irsa-policy-arn"]
- module.irsa_cas2.module.iam_assumable_role.aws_iam_role_policy_attachment.this["/hmpps-audit-prod/sqs/Digital-Prison-Services-prod-hmpps_audit_queue/irsa-policy-arn"]
- module.irsa_ta.module.iam_assumable_role.aws_iam_role_policy_attachment.this["/hmpps-audit-prod/sqs/Digital-Prison-Services-prod-hmpps_audit_queue/irsa-policy-arn"]

@sablumiah
Copy link
Contributor

This PR CANNOT be auto approved and requires manual approval from the Cloud Platform team.
Reason:
🕵️‍♂️ Manual review required: OPA policy checks did not pass.
Please raise it in #ask-cloud-platform Slack channel.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

@besscerule besscerule force-pushed the feature/CAS-1390-Create-SQS-Queue-to-subscribe-to-HmppsDomainEvents-topic-prod-env branch from ff28eac to b95921c Compare February 13, 2025 15:45
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

@sablumiah
Copy link
Contributor

Terraform Plan Summary

Terraform Plan: 16 to be created, 5 to be destroyed, 0 to be updated, 0 to be replaced and 41 unchanged.

Resources to create:

+ aws_sns_topic_subscription.cas-2-domain-events-listener-queue-subscription
+ aws_sqs_queue_policy.cas-2-domain-events-listener-dlq-policy
+ aws_sqs_queue_policy.cas-2-domain-events-listener-queue-policy
+ kubernetes_secret.cas-2-domain-events-listener-dlq-secret
+ kubernetes_secret.cas-2-domain-events-listener-queue-secret
+ module.cas-2-domain-events-listener-dlq.aws_iam_policy.irsa
+ module.cas-2-domain-events-listener-dlq.aws_sqs_queue.terraform_queue
+ module.cas-2-domain-events-listener-dlq.random_id.id
+ module.cas-2-domain-events-listener-queue.aws_iam_policy.irsa
+ module.cas-2-domain-events-listener-queue.aws_sqs_queue.terraform_queue
+ module.cas-2-domain-events-listener-queue.random_id.id
+ module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["cas-2-sns"]
+ module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["domain_events_topic"]
+ module.irsa_ap.module.iam_assumable_role.aws_iam_role_policy_attachment.this["audit_sqs"]
+ module.irsa_cas2.module.iam_assumable_role.aws_iam_role_policy_attachment.this["audit_sqs"]
+ module.irsa_ta.module.iam_assumable_role.aws_iam_role_policy_attachment.this["audit_sqs"]

Resources to destroy:

- module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["/hmpps-domain-events-prod/sns/cloud-platform-Digital-Prison-Services-97e6567cf80881a8a52290ff2c269b08/irsa-policy-arn"]
- module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["rds"]
- module.irsa_ap.module.iam_assumable_role.aws_iam_role_policy_attachment.this["/hmpps-audit-prod/sqs/Digital-Prison-Services-prod-hmpps_audit_queue/irsa-policy-arn"]
- module.irsa_cas2.module.iam_assumable_role.aws_iam_role_policy_attachment.this["/hmpps-audit-prod/sqs/Digital-Prison-Services-prod-hmpps_audit_queue/irsa-policy-arn"]
- module.irsa_ta.module.iam_assumable_role.aws_iam_role_policy_attachment.this["/hmpps-audit-prod/sqs/Digital-Prison-Services-prod-hmpps_audit_queue/irsa-policy-arn"]

@sablumiah
Copy link
Contributor

This PR CANNOT be auto approved and requires manual approval from the Cloud Platform team.
Reason:
🕵️‍♂️ Manual review required: OPA auto approve policy checks did not pass.
Please raise it in #ask-cloud-platform Slack channel.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR affects multiple namespaces

  • hmpps-community-accommodation-dev
  • hmpps-community-accommodation-prod
    Please submit a separate PR for each namespace.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

@sablumiah
Copy link
Contributor

Terraform Plan Summary

Terraform Plan: 0 to be created, 0 to be destroyed, 18 to be updated, 0 to be replaced and 68 unchanged.

Resources to update:

! module.cas-2-domain-events-listener-dlq.aws_iam_policy.irsa
! module.cas-2-domain-events-listener-dlq.aws_sqs_queue.terraform_queue
! module.cas-2-domain-events-listener-queue.aws_iam_policy.irsa
! module.cas-2-domain-events-listener-queue.aws_sqs_queue.terraform_queue
! module.elasticache_redis.aws_elasticache_replication_group.ec_redis
! module.elasticache_redis.aws_elasticache_subnet_group.ec_subnet
! module.elasticache_redis.aws_iam_policy.irsa
! module.elasticache_redis.aws_security_group.ec
! module.irsa.module.iam_assumable_role.aws_iam_role.this[0]
! module.irsa_ap.module.iam_assumable_role.aws_iam_role.this[0]
! module.irsa_cas2.module.iam_assumable_role.aws_iam_role.this[0]
! module.irsa_ta.module.iam_assumable_role.aws_iam_role.this[0]
! module.rds.aws_db_instance.rds
! module.rds.aws_db_parameter_group.custom_parameters
! module.rds.aws_db_subnet_group.db_subnet[0]
! module.rds.aws_iam_policy.irsa
! module.rds.aws_kms_key.kms[0]
! module.rds.aws_security_group.rds-sg

@sablumiah
Copy link
Contributor

Terraform Plan Summary

Terraform Plan: 16 to be created, 5 to be destroyed, 0 to be updated, 0 to be replaced and 41 unchanged.

Resources to create:

+ aws_sns_topic_subscription.cas-2-domain-events-listener-queue-subscription
+ aws_sqs_queue_policy.cas-2-domain-events-listener-dlq-policy
+ aws_sqs_queue_policy.cas-2-domain-events-listener-queue-policy
+ kubernetes_secret.cas-2-domain-events-listener-dlq-secret
+ kubernetes_secret.cas-2-domain-events-listener-queue-secret
+ module.cas-2-domain-events-listener-dlq.aws_iam_policy.irsa
+ module.cas-2-domain-events-listener-dlq.aws_sqs_queue.terraform_queue
+ module.cas-2-domain-events-listener-dlq.random_id.id
+ module.cas-2-domain-events-listener-queue.aws_iam_policy.irsa
+ module.cas-2-domain-events-listener-queue.aws_sqs_queue.terraform_queue
+ module.cas-2-domain-events-listener-queue.random_id.id
+ module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["cas-2-sns"]
+ module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["domain_events_topic"]
+ module.irsa_ap.module.iam_assumable_role.aws_iam_role_policy_attachment.this["audit_sqs"]
+ module.irsa_cas2.module.iam_assumable_role.aws_iam_role_policy_attachment.this["audit_sqs"]
+ module.irsa_ta.module.iam_assumable_role.aws_iam_role_policy_attachment.this["audit_sqs"]

Resources to destroy:

- module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["/hmpps-domain-events-prod/sns/cloud-platform-Digital-Prison-Services-97e6567cf80881a8a52290ff2c269b08/irsa-policy-arn"]
- module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["rds"]
- module.irsa_ap.module.iam_assumable_role.aws_iam_role_policy_attachment.this["/hmpps-audit-prod/sqs/Digital-Prison-Services-prod-hmpps_audit_queue/irsa-policy-arn"]
- module.irsa_cas2.module.iam_assumable_role.aws_iam_role_policy_attachment.this["/hmpps-audit-prod/sqs/Digital-Prison-Services-prod-hmpps_audit_queue/irsa-policy-arn"]
- module.irsa_ta.module.iam_assumable_role.aws_iam_role_policy_attachment.this["/hmpps-audit-prod/sqs/Digital-Prison-Services-prod-hmpps_audit_queue/irsa-policy-arn"]

@daveawc daveawc force-pushed the feature/CAS-1390-Create-SQS-Queue-to-subscribe-to-HmppsDomainEvents-topic-prod-env branch from eb4a438 to c532caa Compare February 19, 2025 13:23
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

@sablumiah
Copy link
Contributor

Terraform Plan Summary

Terraform Plan: 16 to be created, 5 to be destroyed, 0 to be updated, 0 to be replaced and 41 unchanged.

Resources to create:

+ aws_sns_topic_subscription.cas-2-domain-events-listener-queue-subscription
+ aws_sqs_queue_policy.cas-2-domain-events-listener-dlq-policy
+ aws_sqs_queue_policy.cas-2-domain-events-listener-queue-policy
+ kubernetes_secret.cas-2-domain-events-listener-dlq-secret
+ kubernetes_secret.cas-2-domain-events-listener-queue-secret
+ module.cas-2-domain-events-listener-dlq.aws_iam_policy.irsa
+ module.cas-2-domain-events-listener-dlq.aws_sqs_queue.terraform_queue
+ module.cas-2-domain-events-listener-dlq.random_id.id
+ module.cas-2-domain-events-listener-queue.aws_iam_policy.irsa
+ module.cas-2-domain-events-listener-queue.aws_sqs_queue.terraform_queue
+ module.cas-2-domain-events-listener-queue.random_id.id
+ module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["cas-2-sns"]
+ module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["domain_events_topic"]
+ module.irsa_ap.module.iam_assumable_role.aws_iam_role_policy_attachment.this["audit_sqs"]
+ module.irsa_cas2.module.iam_assumable_role.aws_iam_role_policy_attachment.this["audit_sqs"]
+ module.irsa_ta.module.iam_assumable_role.aws_iam_role_policy_attachment.this["audit_sqs"]

Resources to destroy:

- module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["/hmpps-domain-events-prod/sns/cloud-platform-Digital-Prison-Services-97e6567cf80881a8a52290ff2c269b08/irsa-policy-arn"]
- module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["rds"]
- module.irsa_ap.module.iam_assumable_role.aws_iam_role_policy_attachment.this["/hmpps-audit-prod/sqs/Digital-Prison-Services-prod-hmpps_audit_queue/irsa-policy-arn"]
- module.irsa_cas2.module.iam_assumable_role.aws_iam_role_policy_attachment.this["/hmpps-audit-prod/sqs/Digital-Prison-Services-prod-hmpps_audit_queue/irsa-policy-arn"]
- module.irsa_ta.module.iam_assumable_role.aws_iam_role_policy_attachment.this["/hmpps-audit-prod/sqs/Digital-Prison-Services-prod-hmpps_audit_queue/irsa-policy-arn"]

@sablumiah
Copy link
Contributor

This PR CANNOT be auto approved and requires manual approval from the Cloud Platform team.
Reason:
🕵️‍♂️ Manual review required: OPA auto approve policy checks did not pass.
Please raise it in #ask-cloud-platform Slack channel.

@daveawc daveawc force-pushed the feature/CAS-1390-Create-SQS-Queue-to-subscribe-to-HmppsDomainEvents-topic-prod-env branch from c532caa to 3fa801a Compare February 19, 2025 13:42
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are potential IAM Role and/or policy Changes/additions. Reviewer - If satisfied with the changes/additions - dismiss this request

@sablumiah
Copy link
Contributor

Terraform Plan Summary

Terraform Plan: 16 to be created, 5 to be destroyed, 0 to be updated, 0 to be replaced and 41 unchanged.

Resources to create:

+ aws_sns_topic_subscription.cas-2-domain-events-listener-queue-subscription
+ aws_sqs_queue_policy.cas-2-domain-events-listener-dlq-policy
+ aws_sqs_queue_policy.cas-2-domain-events-listener-queue-policy
+ kubernetes_secret.cas-2-domain-events-listener-dlq-secret
+ kubernetes_secret.cas-2-domain-events-listener-queue-secret
+ module.cas-2-domain-events-listener-dlq.aws_iam_policy.irsa
+ module.cas-2-domain-events-listener-dlq.aws_sqs_queue.terraform_queue
+ module.cas-2-domain-events-listener-dlq.random_id.id
+ module.cas-2-domain-events-listener-queue.aws_iam_policy.irsa
+ module.cas-2-domain-events-listener-queue.aws_sqs_queue.terraform_queue
+ module.cas-2-domain-events-listener-queue.random_id.id
+ module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["cas-2-sns"]
+ module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["domain_events_topic"]
+ module.irsa_ap.module.iam_assumable_role.aws_iam_role_policy_attachment.this["audit_sqs"]
+ module.irsa_cas2.module.iam_assumable_role.aws_iam_role_policy_attachment.this["audit_sqs"]
+ module.irsa_ta.module.iam_assumable_role.aws_iam_role_policy_attachment.this["audit_sqs"]

Resources to destroy:

- module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["/hmpps-domain-events-prod/sns/cloud-platform-Digital-Prison-Services-97e6567cf80881a8a52290ff2c269b08/irsa-policy-arn"]
- module.irsa.module.iam_assumable_role.aws_iam_role_policy_attachment.this["rds"]
- module.irsa_ap.module.iam_assumable_role.aws_iam_role_policy_attachment.this["/hmpps-audit-prod/sqs/Digital-Prison-Services-prod-hmpps_audit_queue/irsa-policy-arn"]
- module.irsa_cas2.module.iam_assumable_role.aws_iam_role_policy_attachment.this["/hmpps-audit-prod/sqs/Digital-Prison-Services-prod-hmpps_audit_queue/irsa-policy-arn"]
- module.irsa_ta.module.iam_assumable_role.aws_iam_role_policy_attachment.this["/hmpps-audit-prod/sqs/Digital-Prison-Services-prod-hmpps_audit_queue/irsa-policy-arn"]

@sablumiah
Copy link
Contributor

This PR CANNOT be auto approved and requires manual approval from the Cloud Platform team.
Reason:
🕵️‍♂️ Manual review required: OPA auto approve policy checks did not pass.
Please raise it in #ask-cloud-platform Slack channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants