Ctskf 833 250123 #8115
Open
Ctskf 833 250123 #8115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
message.rb: Added attachments Added duplicate_message_attachment in after_create doocument.rake: rake task to duplicate message attachment
Remove redundant checking.
Co-authored-by: Joseph Haig <[email protected]>
added count_blob_map
refine the original changes on top of CTSKF-1002
Refinement and comment out test for trial
refine the original changes on top of CTSKF-1002
Refinement and comment out test for trial
tmp fix on the cucumber test
remove has_one_attached :attachment and related function. remove sleep time in messaging_steps.rb remove commented code
remove extra line to pass test
Note that the moj frontend component uses POST for both create and delete.
tidied up the ability file
Added error handling for multi-file-upload.
changed font color
Fixed not showing error returned by the component
Tmp implementation of attaching documents to message
implementation showing multiple attachments
clear the file list after form submit
refine the original changes on top of CTSKF-1002
Refinement and comment out test for trial
tmp fix on the cucumber test
remove has_one_attached :attachment and related function. remove sleep time in messaging_steps.rb remove commented code
remove extra line to pass test
Note that the moj frontend component uses POST for both create and delete.
tidied up the ability file
Added error handling for multi-file-upload.
changed font color
Fixed not showing error returned by the component
Tmp implementation of attaching documents to message
implementation showing multiple attachments
clear the file list after form submit
try to meet Sonarqube standard
fix rspec tests
fix rubocop
revert some of the changes in documents_controller.rb
VinceChiuMOJ
force-pushed
the
CTSKF-833_250123
branch
from
4264c9b to
930c151
Compare
It is not testing the hooks for now.
try to pass the test with minimal check
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
https://dsdmoj.atlassian.net/browse/CTSKF-833
250113 updates:
Checked out a new branch to refine the changes did before on top of CTSKF-1002 and CTSKF-832_250106
250130 updates:
Implemented the functionalities, sorting out the tests