Ctskf 832 - CCCD - Allow for multiple documents on a message #8064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpw5
reviewed
Jan 27, 2025
jrmhaig
approved these changes
Jan 30, 2025
VinceChiuMOJ
force-pushed
the
CTSKF-832_250116
branch
2 times, most recently
from
536f5d2 to
e75e45a
Compare
refine the original changes on top of CTSKF-1002
VinceChiuMOJ
force-pushed
the
CTSKF-832_250116
branch
from
e75e45a to
f48eb9d
Compare
VinceChiuMOJ
force-pushed
the
CTSKF-832_250116
branch
from
f48eb9d to
ed68d1f
Compare
|
VinceChiuMOJ
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
CCCD - Allow for multiple documents on a message
https://dsdmoj.atlassian.net/browse/CTSKF-832
241006 updates:
Changed the attachment variable name to attachments (plural for multiple). New attachments (one) can be added and download afterwards. The old attachment did not work anymore. Fixed by updating the name column in active_storage_attachments.
241025 updates:
Tried to modified rspec tests to pass.
Accidentally fixed the issue for remove file link not showing for attachments.
250113 updates:
Checked out a new branch to refine the changes did before on top of CTSKF-1002.
No idea why there is no change in blob count, will further investigate
250122 updates:
Passed all the tests but there are some uncertainties.
spec/models/message_spec.rb:
Commented out the tests for blob count change. This test may not be applicable when we move on to CTSKF-833 where we create the attachments as documents. Thus the blob will still exist after we remove the message.
features/step_definitions/messaging_steps.rb:
Not sure if it is OK not using those hooks.