Issue #116 Show banner when installing packages using `yum` #119

gbraad · 2017-07-19T05:27:24Z

Deals with #116

It shows unsupported when trying to install
Waits for confirmation before executing the actual yum command
Allows confirmation to be overwritten by using -y in the command

Note:
Banner might need to be more prominent...

gbraad · 2017-07-19T06:03:32Z

@praveenkumar livecd-creator seems to interpret the $@ and $answer, and writes "" to the livecd filesystem.

praveenkumar · 2017-07-19T12:18:55Z

Makefile

@@ -1,6 +1,7 @@
 BUILD_DIR=$(shell pwd)/build
 BIN_DIR=$(BUILD_DIR)/bin
 HANDLE_USER_DATA=$(shell base64 -w 0 scripts/handle-user-data)
+YUM_WRAPPER=$(shell base64 -w 0 scripts/yum-wrapper)


https://github.com/minishift/minishift-centos-iso/blob/master/Makefile#L40-L41 also need to be updated to pass it to kickstart file.

ah, was wondering about this... wondered if livecd-creator created environment variables to be lowercase. awfully distracted at the moment... :-s

praveenkumar · 2017-07-20T02:48:05Z

@gbraad we need to make change to rhel template also because we want this for RHEL iso too right?

gbraad · 2017-07-20T02:55:29Z

I would like to, but can not make this call. As I remember developer tools do not follow the same support anyways. /cc: @LalatenduMohanty

LalatenduMohanty · 2017-07-20T05:41:44Z

@gbraad @praveenkumar Agree, we need to change RHEL ISO also.

LalatenduMohanty · 2017-07-20T05:44:17Z

scripts/yum-wrapper

@@ -0,0 +1,11 @@
+#!/bin/sh
+echo "Installing additional packages is not supported. Continue [y/n]"


I think we need to add more information around this e.g. Installing additional packages is not supported because the way the VM is created. The recommended method is to run applications as containers.

I hope we can refer to a document or a wiki page where we describe the issue in more detail and provide possible alternatives.

I also believe it should be more prominent...

minishift/minishift#1152

gbraad · 2017-07-20T06:22:29Z

RHEL

done...

gbraad · 2017-07-20T07:29:50Z

This includes #123, so if rebasing... that PR should go first

LalatenduMohanty · 2017-07-21T11:13:32Z

scripts/yum-wrapper

+
+function banner() {
+  hr
+  echo -e "\n  Installing additional packages is not supported. For more information, see:"


s/is/are/ . Some how missed it before.

Why 'are'? 'Is' is referring to 'Installing'

Actually... it is referring to an action/verb and not the object. The action is "installing packages" which is a single thing.

Example:

Eating is exhausting

Eating the dish is exhausting

Eating the dishes is exhausting

because 'is' refers to 'eating'.

hferentschik · 2017-07-21T11:36:22Z

centos-7.template

+# Show a warning banner when using yum to install software
+mv /usr/bin/yum /usr/bin/yum-unsupported
+# Place holder for base64 encode yum-wrapper script
+cat > yum-wrapper.base64 << EOF


I think we could simplify this inclusion of encoded data even more, almost to a degree where you just do something like '${yum_wrapper}'. The current approach is quite fragile.

less fragile than including the script and using escaping... but I can try to see if this suggestion works as expected, as it is not really a bash substitution that happens AFAIR.

@gbraad I guess you have fixed as per @hferentschik 's comment or you guys still discussing?

LalatenduMohanty · 2017-07-24T18:44:08Z

@gbraad Please fix the merge conflict.

gbraad · 2017-07-25T00:02:45Z

We need to confirm the link first, before able to merge. Don't want to do 2 pushes to get this done.

LalatenduMohanty · 2017-07-25T06:21:34Z

We need to confirm the link first, before able to merge. Don't want to do 2 pushes to get this done.

Right. First we need https://docs.openshift.org/latest/minishift/using/troubleshooting.html#install-additional-software-not-supported to be up i.e. minishift/minishift#1152

LalatenduMohanty · 2017-07-26T11:12:47Z

scripts/yum-wrapper

+
+function banner() {
+  hr
+  echo -e "Installing additional packages on the root filesystem might exceed the allocated overlay size and lock the Minishift VM. Proceed with the installation at your own risk."


I am not sure about the word overlay size. Not sure what is supposed to mean. @thatdocslady @gbraad can you please explain it a little.

It look sfine to me.

praveenkumar · 2017-07-26T13:22:23Z

Test with RHEL ISO and worked as exected

$ ./minishift ssh
[docker@minishift ~]$ sudo yum install vim
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Installing additional packages on the root filesystem might exceed the allocated overlay size and lock the Minishift VM. Proceed with the installation at your own risk.
For more information, see https://docs.openshift.org/latest/minishift/using/troubleshooting.html#root-filesystem-exceeds-overlay-size
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Are you sure you want to continue? [y/N]
n
[docker@minishift ~]$ sudo yum install vim
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Installing additional packages on the root filesystem might exceed the allocated overlay size and lock the Minishift VM. Proceed with the installation at your own risk.
For more information, see https://docs.openshift.org/latest/minishift/using/troubleshooting.html#root-filesystem-exceeds-overlay-size
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Are you sure you want to continue? [y/N]
y
Loaded plugins: product-id, search-disabled-repos, subscription-manager

gbraad · 2017-07-27T00:32:41Z

@praveenkumar also verify, although late, if yum install -y vim works. It should show the banner, but not show the continue prompt.

gbraad force-pushed the yum-unsupported branch from 38779f4 to 656ce5d Compare July 19, 2017 06:12

gbraad mentioned this pull request Jul 19, 2017

[WIP] Issue #116 remove RPM and Yum #117

Closed

gbraad force-pushed the yum-unsupported branch 8 times, most recently from 549c29f to b6432fb Compare July 19, 2017 12:10

praveenkumar requested changes Jul 19, 2017

View reviewed changes

gbraad force-pushed the yum-unsupported branch 8 times, most recently from 25506a2 to 53b6b01 Compare July 20, 2017 01:49

gbraad mentioned this pull request Jul 20, 2017

Show a banner around YUM that it is not supported in Minishift VM #116

Closed

gbraad changed the title ~~WIP Show banner when installing packages using yum~~ Issue #116 Show banner when installing packages using yum Jul 20, 2017

gbraad force-pushed the yum-unsupported branch from 53b6b01 to d4d252a Compare July 20, 2017 04:25

LalatenduMohanty requested changes Jul 20, 2017

View reviewed changes

gbraad force-pushed the yum-unsupported branch from d4d252a to e680bca Compare July 20, 2017 06:16

gbraad force-pushed the yum-unsupported branch from e680bca to 27bf600 Compare July 20, 2017 07:12

gbraad force-pushed the yum-unsupported branch from 27bf600 to 3d05a98 Compare July 21, 2017 02:30

LalatenduMohanty requested changes Jul 21, 2017

View reviewed changes

hferentschik reviewed Jul 21, 2017

View reviewed changes

gbraad force-pushed the yum-unsupported branch from 3d05a98 to b6cabca Compare July 24, 2017 03:39

LalatenduMohanty changed the title ~~Issue #116 Show banner when installing packages using yum~~ [Do not merge] Issue #116 Show banner when installing packages using yum Jul 25, 2017

gbraad force-pushed the yum-unsupported branch 4 times, most recently from 3baaaa0 to 61e7985 Compare July 26, 2017 10:17

Issue minishift#116 Show banner when installing packages using yum

4ab12f7

gbraad force-pushed the yum-unsupported branch from 61e7985 to 4ab12f7 Compare July 26, 2017 10:39

LalatenduMohanty previously requested changes Jul 26, 2017

View reviewed changes

LalatenduMohanty changed the title ~~[Do not merge] Issue #116 Show banner when installing packages using yum~~ Issue #116 Show banner when installing packages using yum Jul 26, 2017

praveenkumar merged commit 8ef2db5 into minishift:master Jul 26, 2017

gbraad deleted the yum-unsupported branch July 27, 2017 02:38

gbraad restored the yum-unsupported branch July 27, 2017 02:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue #116 Show banner when installing packages using `yum` #119

Issue #116 Show banner when installing packages using `yum` #119

gbraad commented Jul 19, 2017 •

edited

Loading

gbraad commented Jul 19, 2017

praveenkumar Jul 19, 2017

gbraad Jul 19, 2017

praveenkumar commented Jul 20, 2017

gbraad commented Jul 20, 2017

LalatenduMohanty commented Jul 20, 2017

LalatenduMohanty Jul 20, 2017

gbraad Jul 20, 2017

gbraad Jul 20, 2017

gbraad commented Jul 20, 2017

gbraad commented Jul 20, 2017

LalatenduMohanty Jul 21, 2017

hferentschik Jul 21, 2017

gbraad Jul 21, 2017 •

edited

Loading

hferentschik Jul 21, 2017

gbraad Jul 21, 2017

LalatenduMohanty Jul 24, 2017

LalatenduMohanty commented Jul 24, 2017

gbraad commented Jul 25, 2017 via email •

edited

Loading

LalatenduMohanty commented Jul 25, 2017 •

edited

Loading

LalatenduMohanty Jul 26, 2017

praveenkumar commented Jul 26, 2017

gbraad commented Jul 27, 2017

		@@ -0,0 +1,11 @@
		#!/bin/sh
		echo "Installing additional packages is not supported. Continue [y/n]"

Issue #116 Show banner when installing packages using yum #119

Issue #116 Show banner when installing packages using yum #119

Conversation

gbraad commented Jul 19, 2017 • edited Loading

gbraad commented Jul 19, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

praveenkumar commented Jul 20, 2017

gbraad commented Jul 20, 2017

LalatenduMohanty commented Jul 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gbraad commented Jul 20, 2017

gbraad commented Jul 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gbraad Jul 21, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LalatenduMohanty commented Jul 24, 2017

gbraad commented Jul 25, 2017 via email • edited Loading

LalatenduMohanty commented Jul 25, 2017 • edited Loading

Choose a reason for hiding this comment

praveenkumar commented Jul 26, 2017

gbraad commented Jul 27, 2017

Issue #116 Show banner when installing packages using `yum` #119

Issue #116 Show banner when installing packages using `yum` #119

gbraad commented Jul 19, 2017 •

edited

Loading

gbraad Jul 21, 2017 •

edited

Loading

gbraad commented Jul 25, 2017 via email •

edited

Loading

LalatenduMohanty commented Jul 25, 2017 •

edited

Loading