Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grafana for prometheus #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

durandom
Copy link
Contributor

fixes Issue #52

grafana for prometheus based on https://github.com/mrsiano/grafana-ocp

@durandom
Copy link
Contributor Author

cc @mrsiano as this is based on your work 🙇


## Prerequisites

The prometheus addon is required
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a good practice to tell how much RAM and CPU needs to be allocated to Minishift for this to run smoothly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grafana requires very little memory and cpu. it's merely to display data from its configured backend
see here


```
minishift addon install prometheus-3.7
minishift addon apply prometheus-3.7 --addon-env namespace=kube-system
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This command is wrong as it should be minishift addon install grafana-prometheus. We need to pass the directory name to the addon install command.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's about installing the pre-requisite prometheus - not the grafana addon

To deploy grafana do:

```
minishift addon apply grafana --addon-env namespace=grafana
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like not must be 'grafana_namespace' instead of 'namespace' and 'grafana-prometheus' instead of 'grafana'

Delete grafana with:

```
oc delete project -n grafana --as=system:admin
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice to have grafana-prometheus.addon.remove file also

@dmvolod
Copy link

dmvolod commented May 11, 2018

Any chance to have this addon to be released?

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@mrsiano
Copy link

mrsiano commented May 13, 2018

@dmvolod
Copy link

dmvolod commented May 14, 2018

@mrsiano , thanks for recommendations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants