-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grafana for prometheus #53
base: master
Are you sure you want to change the base?
Conversation
grafana for prometheus based on https://github.com/mrsiano/grafana-ocp
7a5ee10
to
448465d
Compare
cc @mrsiano as this is based on your work 🙇 |
|
||
## Prerequisites | ||
|
||
The prometheus addon is required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a good practice to tell how much RAM and CPU needs to be allocated to Minishift for this to run smoothly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grafana requires very little memory and cpu. it's merely to display data from its configured backend
see here
|
||
``` | ||
minishift addon install prometheus-3.7 | ||
minishift addon apply prometheus-3.7 --addon-env namespace=kube-system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command is wrong as it should be minishift addon install grafana-prometheus
. We need to pass the directory name to the addon install
command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's about installing the pre-requisite prometheus - not the grafana addon
To deploy grafana do: | ||
|
||
``` | ||
minishift addon apply grafana --addon-env namespace=grafana |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like not must be 'grafana_namespace' instead of 'namespace' and 'grafana-prometheus' instead of 'grafana'
Delete grafana with: | ||
|
||
``` | ||
oc delete project -n grafana --as=system:admin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's nice to have grafana-prometheus.addon.remove file also
Any chance to have this addon to be released? |
Can one of the admins verify this patch? |
please consider that some things were changed. |
@mrsiano , thanks for recommendations |
fixes Issue #52
grafana for prometheus based on https://github.com/mrsiano/grafana-ocp