-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node.js imagestream with RHOAR version included #142
base: master
Are you sure you want to change the base?
node.js imagestream with RHOAR version included #142
Conversation
Can one of the admins verify this patch? |
add-ons/nodejs/nodejs.addon
Outdated
# Url: https://github.com/bucharest-gold/centos7-s2i-nodejs | ||
# Maintainer: Jorge Morales <[email protected]> | ||
|
||
oc apply -f https://raw.githubusercontent.com/bucharest-gold/centos7-s2i-nodejs/master/imagestreams/nodejs-centos7.json -n openshift |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorgemoralespou will this link will be always updated one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@praveenkumar As I understand it, yes, but I'll switch it to the openshift/library one:
https://raw.githubusercontent.com/openshift/library/master/community/nodejs/imagestreams/nodejs-centos7.json
@praveenkumar Updated. This can be "squash and merged" when accepting the PR (https://help.github.com/articles/about-pull-request-merges/). I'm a git noob, I don't really know how to do it on the client side :-( |
@jorgemoralespou we can fix it during merging as you mentioned. Don't worry about it. |
Replaces #96