Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #109 Rocket.Chat addon #110

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Issue #109 Rocket.Chat addon #110

wants to merge 2 commits into from

Conversation

edmacabebe
Copy link

Contributing this with this intent of primarily paying back to the community. In addition

  1. That Dev teams may find this useful for their private communication requirements
  2. And for possible poc place for demo/training purpose
  3. Possible integration to hubot, hubot-like capabilities for automated CICD event notifications

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@gbraad
Copy link
Member

gbraad commented Apr 18, 2018

add to whitelist

coolbrg
coolbrg suggested changes Apr 19, 2018
View reviewed changes
Copy link
Contributor

@coolbrg coolbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edmacabebe Can you add basic tests? Refer https://github.com/minishift/minishift-addons/blob/master/TESTING.adoc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coolbrg coolbrg coolbrg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edmacabebe @centos-ci @gbraad @coolbrg