support globs in replacements path #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Magic-Mayo
force-pushed
the
filepath-globs
branch
from
a33bf1b
to
c171de2
Compare
Magic-Mayo
force-pushed
the
filepath-globs
branch
from
c171de2
to
fcbd67e
Compare
Magic-Mayo
commented
Sep 12, 2024
miniscruff
reviewed
Sep 12, 2024
We do not need to fully test the glob system, just a few files will be more than enough here.
|
@Magic-Mayo made a few tweaks and added back the test for a slightly different but equal test case. Just leaving the PR open so you can just validate I didn't butcher your request. |
Either way it's getting the functionality in...doesn't matter much to me what it looks like. I appreciate the help in getting everything up to "code" |
miniscruff
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #713
Check the following
Additional context
Any additional info that might help get your pull request merged.