Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to include keys for kind configs #657

Merged
merged 2 commits into from
May 13, 2024
Merged

Conversation

miniscruff
Copy link
Owner

Closes #612

Check the following

  • Maintain high code coverage
  • Be properly formatted
  • Documentation changes are included
  • Include a change file if expected

Copy link

codacy-production bot commented May 12, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.23% (target: -1.00%) 70.37%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (fa5835d) 2395 2231 93.15%
Head commit (d93061f) 2431 (+36) 2259 (+28) 92.92% (-0.23%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#657) 27 19 70.37%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@miniscruff
Copy link
Owner Author

cc @sheldonhull related to #612

@miniscruff miniscruff merged commit 4cafb25 into main May 13, 2024
7 checks passed
@miniscruff miniscruff deleted the 612-kind-config-key-value branch May 13, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kinds doesn't support a key value, so can cause invalid characters in file names
1 participant