Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to edit body messages with defined editor #513

Merged
merged 22 commits into from
Aug 15, 2023

Conversation

wizsk
Copy link
Contributor

@wizsk wizsk commented Aug 4, 2023

Closes #505

Check the following

  • Keep 100% code coverage
  • Be properly formatted
  • Documentation changes are included
  • Include a change file if expected

Additional context
initial request for feedback..

@wizsk wizsk closed this Aug 4, 2023
@wizsk wizsk reopened this Aug 4, 2023
@wizsk wizsk marked this pull request as draft August 4, 2023 13:46
@miniscruff miniscruff self-requested a review August 4, 2023 16:03
core/config.go Outdated Show resolved Hide resolved
core/config.go Outdated Show resolved Hide resolved
core/utils.go Outdated Show resolved Hide resolved
core/utils.go Outdated Show resolved Hide resolved
cmd/new.go Outdated Show resolved Hide resolved
core/config.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (aa17f7e) 100.00% compared to head (1cbf21c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #513   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines         1857      1923   +66     
=========================================
+ Hits          1857      1923   +66     
Files Changed Coverage Δ
cmd/new.go 100.00% <100.00%> (ø)
core/change.go 100.00% <100.00%> (ø)
core/utils.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

go.mod Outdated Show resolved Hide resolved
core/utils.go Outdated Show resolved Hide resolved
core/utils.go Outdated Show resolved Hide resolved
@miniscruff miniscruff changed the title open editor when useing "changie new --editor" open editor when using "changie new --editor" Aug 5, 2023
@miniscruff miniscruff changed the title open editor when using "changie new --editor" option to edit body messages with defined editor Aug 5, 2023
Copy link
Owner

@miniscruff miniscruff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few smaller comments before you start tests.

core/utils.go Outdated Show resolved Hide resolved
core/utils.go Outdated Show resolved Hide resolved
core/utils.go Outdated Show resolved Hide resolved
core/utils.go Outdated Show resolved Hide resolved
core/utils.go Outdated Show resolved Hide resolved
@miniscruff
Copy link
Owner

@wizsk if you get busy let me know and I can finish up

core/utils_test.go Outdated Show resolved Hide resolved
@wizsk
Copy link
Contributor Author

wizsk commented Aug 11, 2023

hey @miniscruff
i made the changes please review them and let me know if anything needs to be changed

@miniscruff miniscruff marked this pull request as ready for review August 14, 2023 08:09
@miniscruff
Copy link
Owner

@wizsk I went ahead and finished up the tests and did some refactoring along the way now that I had the code in front of me. I also wrote a change fragment and marked the PR as ready. I will merge it tomorrow after work. Thanks again.

@wizsk
Copy link
Contributor Author

wizsk commented Aug 14, 2023

@miniscruff welcome and thanks for all the help

@miniscruff miniscruff merged commit 14e9b2a into miniscruff:main Aug 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow using your editor to create body messages
2 participants