kes: use global math/rand instead of math/rand.New
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reverts to the global `math/rand` RNG.
The global RNG is safe for current use - due to its source.
The default `rand.NewSource` is not safe for concurrent usage.
This can cause crashes like the following:
```
panic: runtime error: index out of range [-1]
goroutine 3902089 [running]:
math/rand.(*rngSource).Uint64(...)
math/rand/rng.go:249
math/rand.(*rngSource).Int63(0x0?)
math/rand/rng.go:234 +0x85
math/rand.(*Rand).Int63(...)
math/rand/rand.go:96
math/rand.(*Rand).Int31(...)
math/rand/rand.go:110
math/rand.(*Rand).Int31n(0x454c860?, 0x1?)
math/rand/rand.go:142 +0x6a
math/rand.(*Rand).Intn(0xc00f099020?, 0x1d?)
math/rand/rand.go:183 +0x25
github.com/minio/kms-go/kes.(*loadBalancer).Send(0xc000afeba0, {0x68bcb58, 0x91fb380}, 0xc0192ce720, {0x4805358, 0x4},
```
Signed-off-by: Andreas Auernhammer <[email protected]>
harshavardhana
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reverts to the global
math/randRNG. The global RNG is safe for current use - due to its source. The defaultrand.NewSourceis not safe for concurrent usage.This can cause crashes like the following: