Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix piped sh usage #929

Merged
merged 1 commit into from
Aug 22, 2024
Merged

docs: fix piped sh usage #929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/installation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ $ kubectl directpv install --openshift
#### Installing by generating DirectPV manifests
To install using generated manifests file, run below command
```sh
$ curl -sfL https://github.com/minio/directpv/raw/master/docs/tools/install.sh | sh - apply
$ curl -sfL https://github.com/minio/directpv/raw/master/docs/tools/install.sh | sh -s - apply
```

## What's next
Expand Down
2 changes: 1 addition & 1 deletion docs/tools/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ function check_directcsi_consistency() {
}

function is_psp_found() {
kubectl get --ignore-not-found=true psp directpv-min-io --no-headers -o NAME | grep -q .
kubectl get --ignore-not-found=true psp directpv-min-io --no-headers -o NAME 2>/dev/null | grep -q .
}

function init() {
Expand Down
2 changes: 1 addition & 1 deletion docs/upgrade.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Follow the below steps for an in-place upgrade
1. Upgrade DirectPV plugin by [this documentation](#upgrade-directpv-plugin).
2. Run install script with appropriate node-selector, tolerations, and `KUBELET_DIR_PATH` environment variable. Below is an example:
```sh
$ curl -sfL https://github.com/minio/directpv/raw/master/docs/tools/install.sh | sh - apply
$ curl -sfL https://github.com/minio/directpv/raw/master/docs/tools/install.sh | sh -s - apply
```

### Upgrade legacy DirectCSI CSI driver
Expand Down
Loading