Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #23 - Restores label basic functionality #75

Closed
wants to merge 2 commits into from

Conversation

ramaroberto
Copy link

I tried to satisfy the requirement described in the issue #23. Maybe it's not the best solution or has a bug I didn't ran into, but at least it's working for me.

It's highly recommended to check the solution.

Robert.

@aAXEe
Copy link
Contributor

aAXEe commented Jan 1, 2016

Your solution fixes the problem that clicking on the labels do not change the value for me.
But it "disables" the click function on the toggle itself. In detail: the toggle() function seems to be called twice in that cases: once from your handler in line 35 and once from the old handler in line 186.

From my tests the old handler can be removed.
Update: should be moved in the else branch of if (this.$element.parent().prop('tagName') == 'LABEL') {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants