renamed deprecated unsafe lifecycle methods #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you guys going to PR this and do another release soon? This is causing issues with SSR since your event registration happens on the server (it causes a memory leak) when this component is in page that's rendered dynamically on the server. It basically turns SSR server into a hobbling zombie. |
|
I am not going to do release new version. But to fix this issue I need to upgrade the react version too. I am going to make a commit to do this. Maybe your problem is about old version of react. Are you using the same react version with react-notifications in your project? |
|
react 16. |
|
But even in React 15, it is not the right place for registering events. https://react-legacy.netlify.com/docs/react-component.html#componentwillmount |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of react 16.3,
componentWillMount,componentWillUpdateandcomponentWillReceivePropslifecycle methods needs to be renamed to supress the warning about deprecation.more info here: https://hackernoon.com/problematic-react-lifecycle-methods-are-going-away-in-react-17-4216acc7d58b