Set volumetric lighting strength #3158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a game, it's MTG's responsibility to choose a value here so that players can use the volumetric lighting effect. It shouldn't be necessary for every MTG server install a separate mod that enables volumetric lighting if their players want to use it. This is the same situation as with dynamic shadows.
The value chosen here (0.2) results in the effective volumetric light strength originally chosen by x2048, before volumetric lighting was made game-customizable: https://github.com/minetest/minetest/blob/master/client/shaders/volumetric_light/opengl_fragment.glsl#L93-L94
It's not like this is forcing anything on players or server owners either, the weather API provides overridable callbacks or can be disabled entirely.