Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the possibility to put fire in a protected area #3129

Merged
merged 2 commits into from
Jun 22, 2024
Merged

Fix the possibility to put fire in a protected area #3129

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f49f9b
Fix the possibility to put fire in a protected area
andriyndev Jun 14, 2024
98482d9
Fix for defined on_ignite(), use minetest.record_protection_violation()
andriyndev Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mods/fire/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ minetest.register_tool("fire:flint_and_steel", {
if not nodedef then
return
end
if minetest.is_protected(pointed_thing.under, player_name) then
if minetest.is_protected(pointed_thing.under, player_name)
or minetest.is_protected(pointed_thing.above, player_name) then
minetest.chat_send_player(player_name, "This area is protected")
return
end
Copy link
Contributor

@Emojigit Emojigit Jun 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend firing on violation callbacks too, i.e.:

if minetest.is_protected(pointed_thing.under, player_name) then
	minetest.record_protection_violation(pointed_thing.under, player_name)
	return
elseif minetest.is_protected(pointed_thing.above, player_name) then
	minetest.record_protection_violation(pointed_thing.above, player_name)
	return
end

For most protection mods, they do the notification for you. Don't worry about the "This area is protected" message.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thank you!

Expand Down